Would it be simpler just to maintain an array in the store of the unique event names that have been sent?

That way we don't have to default the map of every single event during initialisation, we don't have to worry about adding new events down the line and ensuring we default those also, plus we can simplify the logic here and always append the event name and just save the Set to remove any duplicates?

Indeed, removed the initialisation in the constructor and as you mentioned much simpler to just maintain what we already sent and not bother with new events.

We discussed the importance of keeping this state as isolated as possible to potentially persist between installs, so should this be in it's own electron store and therefore a separate file?

I'm not sure what segmentApiCalls does in truth, but I'm assuming it could still function in a separate store.

I've just put this state isolated in its own electron store, now should be fine.
Now the segmentApiCalls I'm removing it as there is no usage at the moment with this approach.

As mentioned in the other PR, i'd vote to put these directly on the electronBridge and to remove this helper method.

Do we need the Boolean( here? Won't includes return a boolean already and the negation keep it as a boolean?

Would it be clearer to rename this processedEvents or seenEvents?

As this is visible in the filesystem, should we keep it generic and maybe just call it mmd-desktop-metrics?

Just for visibility as we discussed in a channel apart, I'm not using mmd-desktop-metrics just because it will clash with the first electron store we have in metrics.

Shouldn't those be saved only if MetricsDecision.PENDING?

this.saveProcessedEvents is saving the names of the events that were already triggered that way we know if it's the first time we track the event and include a property to further be filtered.

Makes sense. Naming is confusing though. Should we rename it to saveProcessedEventName? Also we should rename the method signature. Should reveive an eventName: string instead of a event: string. That will make the signature consistent with both the saveProcessedEvents and the ipcMain.handle('analytics-track'....