This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Create new e2e tests for desktop app UI#250
Merged
racitores merged 53 commits intomain-desktopfrom Nov 29, 2022
Merged
Conversation
662a219 to
c054ab9
Compare
legobeat
reviewed
Nov 21, 2022
cryptotavares
approved these changes
Nov 22, 2022
2681a9e to
7c5be02
Compare
Socket Security Pull Request ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
😵💫 Bin script confusionThis package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack Consider removing one of the conflicting packages. Packages should only export bin scripts with their name
Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
Member
|
LGTM, ready to ship after rebase and green CI 🚀🚀🚀 |
OGPoyraz
approved these changes
Nov 23, 2022
7c5be02 to
25a2603
Compare
58eef82 to
18565fb
Compare
matthewwalsh0
approved these changes
Nov 29, 2022
e6b8bd5 to
f16e16f
Compare
cryptotavares
approved these changes
Nov 29, 2022
Update Playwright README. Add example env file. Fix linting issues.
f16e16f to
08c3b28
Compare
bergarces
pushed a commit
that referenced
this pull request
Dec 5, 2022
* chore: first commit * fix: circleci 2 * fix: circleci 3 * fix: circleci 4 * fix: circleci 5 * fix: circle 6 * temp * temp 3 * temp 4 * temp 5 * temp 7 * temp 8 * temp 9 * temp 10 * temp 11 * temp 12 * temp 13 * temp 14 * fix. config.yml * update: config.yml * update: config.yml * update: config.yml * Updated config.yml * fix: config.yml * fix: lint * fix: lint * fix: lint * move playwright in monorepo * update package.json and README * update config.yml * fix rebase error * fix pipeline issues * fix config.yml * fix config.yml and test * debug pipeline * refactor code * fix circleci * check screenshots * check screenshots * code refactor * clean code * remove white spaces * PR comments fix * update test * fix issue in ci * fix MM e2e * fix lint * fix UTs * fix uts * fix dir mapping clashing in test circleci * Fix minor issues after rebase Update Playwright README. Add example env file. Fix linting issues. * Fix moving builds in CI * remove log file Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Desktop project needs tests for the desktop UI side. This PR aims to add the basic infrastructure to start adding tests one the desktop UI side is ready to be tested.
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.