## Changes

### Critical Fixes
- Fix `interface` → `type` inconsistency in component-architecture.md
  - All shared props now use `type` not `interface` (aligns with ESLint rule)
  - Updated 6 instances across the file

- Replace duplicated BadgeStatus examples with @ references
  - Removed ~125 lines of duplicated code across files
  - Now references actual implementation as SOURCE OF TRUTH

### Code Duplication Reduction
- Consolidate Button type examples across 3 files
  - Reference BadgeStatus golden path instead of duplicating patterns

- Consolidate styling examples
  - Reference WalletHome.stories.tsx and styling.md instead of duplicating

### Clarity Improvements
- Add prominent BadgeStatus golden path callouts
  - Clearly marked as "THE proof-of-concept" and "SOURCE OF TRUTH"
  - Added in component-architecture.md, component-creation.md, component-enum-union-migration.md

- Add warnings to template references
  - ⚠️ callouts explaining templates are NOT ADR-compliant
  - 4 transformation steps required after scaffolding

- Enhance story naming examples
  - Added 5 concrete examples (variant → Variant, size → Size, etc.)

## Benefits
- Reduced maintenance: Code examples reference actual implementations
- Single source of truth: BadgeStatus is THE canonical example
- Consistency: All docs use same patterns
- Clarity: AI agents get non-contradictory guidance
- Up-to-date: References stay current automatically

## Files Modified
- .cursor/rules/component-architecture.md
- .cursor/rules/component-creation.md
- .cursor/rules/component-migration.md
- .cursor/rules/component-enum-union-migration.md
- .cursor/rules/component-documentation.md

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Address PR review feedback from georgewrmarshall:
- Add ADR links in Purpose section of component-architecture.md
- Update all ADR references from PR links to main branch document links
- Ensures documentation remains accessible even after PRs are merged

Changes:
- component-architecture.md: Added clickable ADR links in Purpose section (lines 9-10)
- Updated ADR-0003 reference from PR #127 to document link (line 58)
- Updated ADR-0004 reference from PR #128 to document link (line 166)
- Updated References section ADR links (lines 398-399)
- component-creation.md: Updated ADR links in MetaMask Standards section
- component-migration.md: Updated ADR links in Architecture Decision Records section
- component-enum-union-migration.md: Updated ADR links in Architecture Decision Records section

All ADR references now point to:
- https://github.com/MetaMask/decisions/blob/main/decisions/design-system/0003-enum-to-string-union-migration.md
- https://github.com/MetaMask/decisions/blob/main/decisions/design-system/0004-centralized-types-architecture.md

Related: #911 (review comments)

Following ai-agents.md principle: '200-400 lines per file (checklists, not novels)'

Changes:
- component-creation.md: 661 → 355 lines (46% reduction)
  - Replaced full code examples with references to BadgeStatus
  - Merged React/React Native steps (95% identical)
  - Condensed tutorials to actionable checklists

- component-migration.md: 440 → 332 lines (24% reduction)
  - Condensed audit phase tutorial to checklist
  - Referenced component-creation.md and styling.md for implementation
  - Collapsed scenarios to decision tree

- component-enum-union-migration.md: 403 → 218 lines (46% reduction)
  - Referenced component-architecture.md for all patterns
  - Removed duplicated type examples
  - Converted steps to workflow checklist

- figma-integration.md: 423 → 303 lines (28% reduction)
  - Combined six prop mapping examples into one comprehensive
  - Removed repetitive wizard steps
  - Streamlined critical rules to checklist

Total: 2,730 → 2,011 lines (26% reduction, 719 lines saved)

All files now closer to 200-400 line target while maintaining effectiveness
as AI agent guardrails using 'reference over duplication' principle.

Following ai-agents.md principle: '200-400 lines per file (checklists, not novels)'

Changes:
- component-architecture.md: 410 → 168 lines (59% reduction)

Condensation strategies:
- Removed ADR benefits/usage sections, linked to ADRs instead
- Condensed full three-layer example to minimal pattern + reference
- Merged decision table + quick rules - removed redundancy
- Kept BadgeStatus references prominent

Final status: ALL cursor rules files now within 200-400 line target:
  109 component-documentation.md
  168 component-architecture.md ✅
  224 component-enum-union-migration.md
  284 styling.md
  306 figma-integration.md
  342 component-migration.md
  357 component-creation.md
  1790 total (was 2730, saved 940 lines / 34% reduction)

Updated cursor rules to document correct export pattern:
- Component index.ts exports directly from @metamask/design-system-shared
- Platform src/types/index.ts should NOT re-export shared types
- Added verification checklist items for correct pattern

Files updated:
- component-enum-union-migration.md: Updated step 4, added step 5
- component-architecture.md: Added "Component Index Export Pattern" section
- component-creation.md: Added checklist item for export pattern

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Updated component creation documentation to prevent duplicate enum exports
that reduce test coverage:

- component-creation.md: Added critical warning that .types.ts files should
  ONLY import, never re-export enums. Enums exported from index.ts only.
- component-enum-union-migration.md: Clarified migration pattern with
  explicit examples showing .types.ts import-only pattern.
- Added anti-pattern sections showing the exact issue that caused BadgeCount
  coverage loss.

Pattern:
- .types.ts: Import only (prevents duplicate exports)
- index.ts: Single export location for enums (single source of truth)

This prevents Jest coverage failures from uncovered duplicate export paths.

Replaced "enum" terminology with "const object" throughout documentation
to accurately reflect ADR-0003 pattern and avoid confusion with TypeScript
enums.

Updated terminology:
- "enum exports" → "const object exports"
- "enum re-exports" → "const object re-exports"
- "design token enums" → "design token const objects"

Preserved "enum" only when referring to:
- TypeScript enums in anti-pattern examples
- File names (component-enum-union-migration.md)
- ADR-0003 title references
- Old TypeScript enums being migrated/removed

This clarifies that we're working with const objects (as const), not
TypeScript enums, making the documentation more precise and educational.

Establishes foundational architectural patterns for components:
- ADR-0003: Const objects over TypeScript enums
- ADR-0004: Centralized types in shared package
- Layered architecture with one-way dependencies
- Two-file export pattern preventing test coverage loss

This rule provides the foundation that other cursor rules reference.
Validated through BadgeCount migration (PR #942) which demonstrated
the coverage issue when duplicate exports exist.

References BadgeStatus as the golden path proof-of-concept for
these patterns.