fix: ensure peer dependencies reflect latest breaking changes for pre-1.0 packages#836
Merged
Merged
Conversation
Contributor
📖 Storybook Preview |
brianacnguyen
approved these changes
Sep 19, 2025
Contributor
📖 Storybook Preview |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the peer dependency generation logic for pre-1.0 packages to follow semantic versioning best practices. Previously, all pre-1.0 packages used overly permissive ^0.0.0 ranges, which could allow incompatible versions. The fix ensures peer dependencies reflect the most significant version digit for breaking changes.
- Implements proper version range calculation for pre-1.0 packages based on which version component is non-zero
- Replaces hardcoded
^major.0.0pattern with conditional logic for major, minor, and patch-level versions - Maintains backward compatibility while preventing version mismatches in monorepo dependencies
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
brianacnguyen
pushed a commit
that referenced
this pull request
Dec 9, 2025
## **Description** This PR releases version 17.0.0 of the MetaMask Design System, featuring important fixes for mobile font compatibility, the addition of the ButtonHero component to React, export fixes for React Native, and various dependency updates including ESLint configuration upgrades. ## **Included PRs** #836, #837, #838, #840, #843, #845, #846, #847, #848, #850, #851, #852, #853, #854, #855, #856, #857, #858, #859, #861, #862, #863, #864 ## **Manual testing steps** 1. Check package.json version bumps align with included changes 2. Check changelog accurately reflects the release ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release 17.0.0 introducing React `ButtonHero`, RN font naming changes and TWRNC preset font family rename (both breaking), plus RN export fix and dependency updates. > > - **Release 17.0.0** > - Bump root `package.json` to `17.0.0`. > - **React (`@metamask/design-system-react@0.6.0`)** > - Add `ButtonHero` component for prominent CTAs. > - Update `@metamask/utils` peer to `^11.8.1`. > - **React Native (`@metamask/design-system-react-native@0.5.0`)** > - BREAKING: Rename font files to hyphenated PostScript format for iOS Metro compatibility. > - Export missing `TextButtonSize` enum. > - Peer: require `@metamask/design-system-twrnc-preset@^0.3.0`; update `@metamask/utils` peer. > - **TWRNC preset (`@metamask/design-system-twrnc-preset@0.3.0`)** > - BREAKING: Rename font family names to hyphenated PostScript format for iOS/expo-font. > - **Changelogs** > - Update `CHANGELOG.md` links and entries for all packages. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9a90311. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes peer dependency constraints for pre-1.0 packages in the monorepo. The previous implementation only used major version ranges (
^0.0.0for all pre-1.0 packages), which was too permissive and could allow incompatible older versions. This update ensures peer dependencies correctly reflect the most significant version digit for breaking changes, following semantic versioning best practices for pre-1.0 packages.Same PR in core
Related issues
Fixes:
Manual testing steps
yarn constraintsto verify no constraint violations0.4.1→ generates^0.4.0peer dependency range0.2.1→ generates^0.2.0peer dependency range8.1.1→ generates^8.0.0peer dependency range (unchanged)0.0.5→ generates^0.0.5peer dependency rangeScreenshots/Recordings
Not applicable - this is a build configuration improvement with no visual changes.
Before
Pre-1.0 packages generated overly permissive
^0.0.0peer dependency ranges.After
Pre-1.0 packages generate appropriate ranges:
^0.minor.0for minor-based versions,^0.0.patchfor patch-only versions.Pre-merge author checklist
Pre-merge reviewer checklist