Skip to content

chore: remove unused eslint disable comments#1118

Merged
georgewrmarshall merged 1 commit into
mainfrom
chore/remove-unused-eslint-disables
Apr 27, 2026
Merged

chore: remove unused eslint disable comments#1118
georgewrmarshall merged 1 commit into
mainfrom
chore/remove-unused-eslint-disables

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Description

Removes two unused eslint-disable / eslint-enable wrappers for import-x/no-nodejs-modules in the React and React Native create-component scripts.

These comments are no longer needed and currently show up as warnings in yarn lint.

Related issues

Fixes:

Manual testing steps

  1. Check out this branch.
  2. Run yarn lint.
  3. Confirm the unused eslint-disable warnings are no longer reported.

Screenshots/Recordings

Not applicable.

Before

Not applicable.

After

Not applicable.

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: comment-only lint cleanup with no runtime or behavior changes.

Overview
Removes unused eslint-disable/eslint-enable wrappers for import-x/no-nodejs-modules in the React and React Native create-component scripts, addressing yarn lint warnings without changing script behavior.

Reviewed by Cursor Bugbot for commit c9033d2. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

📖 Storybook Preview

@georgewrmarshall georgewrmarshall marked this pull request as ready for review April 27, 2026 22:28
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner April 27, 2026 22:28
@georgewrmarshall georgewrmarshall self-assigned this Apr 27, 2026
@georgewrmarshall georgewrmarshall enabled auto-merge (squash) April 27, 2026 22:28
@georgewrmarshall georgewrmarshall merged commit a703a66 into main Apr 27, 2026
44 checks passed
@georgewrmarshall georgewrmarshall deleted the chore/remove-unused-eslint-disables branch April 27, 2026 23:00
georgewrmarshall added a commit that referenced this pull request Apr 28, 2026
## **Description**

Removes two unused `eslint-disable` / `eslint-enable` wrappers for
`import-x/no-nodejs-modules` in the React and React Native
create-component scripts.

These comments are no longer needed and currently show up as warnings in
`yarn lint`.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Check out this branch.
2. Run `yarn lint`.
3. Confirm the unused eslint-disable warnings are no longer reported.

## **Screenshots/Recordings**

Not applicable.

### **Before**

Not applicable.

### **After**

Not applicable.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs)
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: comment-only lint cleanup with no runtime or behavior
changes.
> 
> **Overview**
> Removes unused `eslint-disable`/`eslint-enable` wrappers for
`import-x/no-nodejs-modules` in the React and React Native
`create-component` scripts, addressing `yarn lint` warnings without
changing script behavior.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
c9033d2. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
cursor Bot pushed a commit that referenced this pull request Apr 28, 2026
## **Description**

Removes two unused `eslint-disable` / `eslint-enable` wrappers for
`import-x/no-nodejs-modules` in the React and React Native
create-component scripts.

These comments are no longer needed and currently show up as warnings in
`yarn lint`.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Check out this branch.
2. Run `yarn lint`.
3. Confirm the unused eslint-disable warnings are no longer reported.

## **Screenshots/Recordings**

Not applicable.

### **Before**

Not applicable.

### **After**

Not applicable.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs)
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: comment-only lint cleanup with no runtime or behavior
changes.
> 
> **Overview**
> Removes unused `eslint-disable`/`eslint-enable` wrappers for
`import-x/no-nodejs-modules` in the React and React Native
`create-component` scripts, addressing `yarn lint` warnings without
changing script behavior.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
c9033d2. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants