Skip to content

Remove dependency on babel-runtime#21

Merged
legobeat merged 3 commits intoMetaMask:mainfrom
legobeat:deps-remove-babel-runtime
Feb 2, 2024
Merged

Remove dependency on babel-runtime#21
legobeat merged 3 commits intoMetaMask:mainfrom
legobeat:deps-remove-babel-runtime

Conversation

@legobeat
Copy link
Copy Markdown

@legobeat legobeat commented Feb 2, 2024

  • deps: @metamask/ethjs-filter@^0.2.0->^0.3.0

    • package has been migrated to babel v7
  • deps: @metamask/ethjs-util@^0.2.0->^0.3.0

    • package has been migrated to babel v7
  • deps: move babel-runtime to devDependencies

    • No longer needed as runtime dependency; still used by devDep @metamask/ethjs-query 0.5.x, which is currently held back from upgrade to ^0.7.1 to ensure tests are consistent

Blocking

@socket-security
Copy link
Copy Markdown

socket-security bot commented Feb 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/ethjs-filter@0.3.0 None +2 352 kB lgbot
npm/@metamask/ethjs-query@0.5.3 Transitive: eval +14 4.41 MB lgbot
npm/@metamask/ethjs-rpc@0.3.2 None +3 92.5 kB metamaskbot
npm/@metamask/ethjs-util@0.3.0 None +4 522 kB lgbot

🚮 Removed packages: npm/@metamask/ethjs-filter@0.2.0, npm/@metamask/ethjs-query@0.5.1, npm/@metamask/ethjs-rpc@0.3.1

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Feb 2, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Required for @metamask/ethjs-query@^0.5.1, which is held back for
purpose of compatibility testing
@legobeat legobeat force-pushed the deps-remove-babel-runtime branch from 255c01f to b46c594 Compare February 2, 2024 15:39
@legobeat legobeat mentioned this pull request Feb 2, 2024
1 task
@legobeat legobeat requested review from a team, NEllusion, brad-decker and kumavis February 2, 2024 15:41
@legobeat legobeat marked this pull request as ready for review February 2, 2024 15:45
@legobeat legobeat requested a review from Mrtenz February 2, 2024 15:46
Copy link
Copy Markdown

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@legobeat legobeat merged commit c2775bc into MetaMask:main Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants