Skip to content

Bump ethjs- dependencies; bn.js v4-> v5#19

Merged
legobeat merged 7 commits intoMetaMask:mainfrom
legobeat:devDeps-ethjs-babel7
Feb 6, 2024
Merged

Bump ethjs- dependencies; bn.js v4-> v5#19
legobeat merged 7 commits intoMetaMask:mainfrom
legobeat:devDeps-ethjs-babel7

Conversation

@legobeat
Copy link
Copy Markdown

@legobeat legobeat commented Jan 24, 2024

  • Update @metamask/ethjs-* dependencies to versions with babel 7 instead of deprecated babel 6 and bn.js v5 instead of v4
  • Update number-to-bn@1.7.0 to @metamask/number-to-bn@1.7.1
    • New version uses BN.js v5 instead of v4
  • BREAKING: Update bn.js from 4.11.6 to 5.2.1

Blocked by

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 24, 2024

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 24, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/ethjs-query@0.7.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat

This comment was marked as resolved.

@legobeat legobeat changed the title bump ethjs- dependencies Bump ethjs- dependencies; bn.js v4->v5 Feb 2, 2024
@legobeat legobeat changed the title Bump ethjs- dependencies; bn.js v4->v5 Bump ethjs- dependencies; bn.js v4-> v5 Feb 2, 2024
@legobeat legobeat marked this pull request as ready for review February 2, 2024 14:54
@legobeat legobeat requested review from a team, Mrtenz, NEllusion, brad-decker and kumavis February 2, 2024 14:58
@legobeat legobeat marked this pull request as draft February 2, 2024 15:09
@legobeat legobeat marked this pull request as ready for review February 2, 2024 18:36
Copy link
Copy Markdown

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@legobeat legobeat force-pushed the devDeps-ethjs-babel7 branch from c0fbebe to 44822c4 Compare February 6, 2024 14:21
@legobeat legobeat merged commit 3f8dbd9 into MetaMask:main Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants