This repository was archived by the owner on Oct 7, 2024. It is now read-only.
support newer versons of ethereumjs/tx with immutability#61
Merged
brad-decker merged 1 commit intomasterfrom Apr 16, 2021
Merged
support newer versons of ethereumjs/tx with immutability#61brad-decker merged 1 commit intomasterfrom
brad-decker merged 1 commit intomasterfrom
Conversation
37e33b5 to
fb6e9df
Compare
fb6e9df to
0295bdf
Compare
NiranjanaBinoy
approved these changes
Apr 16, 2021
Merged
Gudahtt
added a commit
that referenced
this pull request
Jul 8, 2021
This package was partially replaced by it's successor `@ethereumjs/tx` in #61, but was left around for the unit tests to ensure the keyring was compatible with both versions. Now that we have moved away from using `ethereum-tx` in in MetaMask itself, we don't really need to keep two versions of the same package around anymore.
Gudahtt
added a commit
that referenced
this pull request
Jul 8, 2021
This package was partially replaced by it's successor `@ethereumjs/tx` in #61, but was left around for the unit tests to ensure the keyring was compatible with both versions. Now that we have moved away from using `ethereum-tx` in in MetaMask itself, we don't really need to keep two versions of the same package around anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the sign method relies on mutation, which was the case pre version 3.0.0 of ethereumjs/tx. In earlier versions of the library, the passed tx object was modified. In version 3.0.0 immutability and Object.freeze were implemented, and the newly signed tx is returned as a brand new instance of the Transaction.
The change presented here should allow both versions (mutable and immutable) to function, preferring the immutable version.