This repository was archived by the owner on Oct 7, 2024. It is now read-only.
fix: treat undefined/null as [] in deserialize#163
Merged
legobeat merged 1 commit intoMetaMask:mainfrom Oct 20, 2023
Merged
Conversation
2c410e5 to
317e8bd
Compare
legobeat
added a commit
to legobeat/eth-simple-keyring
that referenced
this pull request
Oct 20, 2023
legobeat
added a commit
to legobeat/eth-simple-keyring
that referenced
this pull request
Oct 23, 2023
3 tasks
legobeat
added a commit
to legobeat/eth-simple-keyring
that referenced
this pull request
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
undefinedas argument todeserializecurrently throws an error. This adds a default argument to match constructor behavior (treat it the same as[]).