Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

fix(publish): mark scripts as executable#157

Merged
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:chore-make-scripts-executable
Sep 13, 2023
Merged

fix(publish): mark scripts as executable#157
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:chore-make-scripts-executable

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Sep 13, 2023

This fixes the failing publish attempt of v5.1.0 by marking the shell scripts under scripts/ as executable.

Related

@legobeat legobeat added the type-bug Something isn't working label Sep 13, 2023
@legobeat legobeat requested a review from a team September 13, 2023 22:42
@legobeat legobeat marked this pull request as ready for review September 13, 2023 22:43
@legobeat legobeat requested a review from a team as a code owner September 13, 2023 22:43
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 839855e into MetaMask:main Sep 13, 2023
@legobeat legobeat deleted the chore-make-scripts-executable branch September 13, 2023 23:02
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
* 5.1.0
* fix incorrect changelog entry for 5.0.0

---------
This was originally merged as d0d5c97
but rebased on top of MetaMask#157 to retrigger the publish.
---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
* 5.1.0
* fix incorrect changelog entry for 5.0.0

---------
This was originally merged as d0d5c97
but rebased on top of MetaMask#157 to retrigger the publish.
---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
* 5.1.0
* fix incorrect changelog entry for 5.0.0

---------
This was originally merged as d0d5c97
but rebased on top of MetaMask#157 to retrigger the publish.
---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
This reverts commit d0d5c97 which released
v5.1.0. This is only done in order to get a proper publish from the
main branch after merge of MetaMask#157, which fixes a CI error.

5.1.0 will be rereleased and published as-is.
@legobeat legobeat mentioned this pull request Sep 14, 2023
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
This reverts commit d0d5c97 which released
v5.1.0. This is only done in order to get a proper publish from the
main branch after merge of MetaMask#157, which fixes a CI error.

5.1.0 will be rereleased and published as-is.
@legobeat legobeat mentioned this pull request Sep 14, 2023
legobeat added a commit that referenced this pull request Sep 15, 2023
This reverts commit d0d5c97 which released
v5.1.0. This is only done in order to get a proper publish from the
main branch after merge of #157, which fixes a CI error.

5.1.0 will be rereleased and published as-is.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type-bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants