chore: fix contract type#59
Conversation
- fix: entries function is actually a Promise - remove type duplication
| @@ -1,14 +1,18 @@ | |||
| declare module '@metamask/ethjs-types' { | |||
There was a problem hiding this comment.
Note that usually type augmentations aren't a good idea because they will only be present locally and will not be included in the type declaration files, so they could cause type errors in another project that uses this package. This seems to be okay for right now because registry is private, so DeployedRegistryContract gets erased from the built type declaration files, but something to keep in mind in case this does cause problems later.
There was a problem hiding this comment.
I don't see how it would cause type-errors? But in any case yes, this "synthetic module" is for internal use only. If reuse elsewhere becomes relevant I guess it also becomes relevant to consider exposing these (for example generated from jsdoc comments) from ethjs-contract and ethjs-query packages themselves.
eth-method-registry/src/index.ts
Line 45 in 4042e9f