Conversation
|
I noticed this doesn't work properly when using both "legacy" and "ledger live" accounts together. Storing the hdPath for each account might help. |
|
Very happy you are working on this! |
|
Can't wait! |
|
We've crowdsourced a substantial bounty if you're able to get this done to the satisfaction of Metamask devs: https://twitter.com/nicksdjohnson/status/1356006896533008384 |
Gudahtt
left a comment
There was a problem hiding this comment.
Thanks for the contribution! We're currently testing these changes in this PR: MetaMask/metamask-extension#10505. We should have more feedback relatively soon.
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM, great work! I appreciate that you added so many tests.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
|
Is this ready for widespread usage? How do I activate this feature? Thank you. |
|
@rmarkdev could you please provide an address for the 1.3 ETH that was pledged for when this was merged? |
* allow adding multiple accounts (MetaMask/metamask-extension#6649) * ensure the unlocked account belongs to the connected device (MetaMask/metamask-extension#6649) * store hdPath for each account * refactor unlockAccountByAddress to async function * improve formatting in _migrateAccountDetails Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
This allows to use multiple accounts from one or more ledger devices simultaneously without setting them up repeatedly (MetaMask/metamask-extension#6649).