This repository was archived by the owner on Oct 16, 2025. It is now read-only.
Merged
Conversation
Gudahtt
reviewed
Sep 4, 2024
Gudahtt
reviewed
Sep 4, 2024
|
|
||
| ## [14.0.1] | ||
| ### Fixed | ||
| - Request validation should not throw if verifyingContract is not defined in typed signature ([#328](https://github.com/MetaMask/eth-json-rpc-middleware/pull/328)) |
Member
There was a problem hiding this comment.
Nit: Is this a better description? The field is in the message, not the message type or the signature for the message.
Suggested change
| - Request validation should not throw if verifyingContract is not defined in typed signature ([#328](https://github.com/MetaMask/eth-json-rpc-middleware/pull/328)) | |
| - Request validation should not throw if verifyingContract is not defined in typed message ([#328](https://github.com/MetaMask/eth-json-rpc-middleware/pull/328)) |
Gudahtt
approved these changes
Sep 4, 2024
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! One suggested improvement to the wording
Gudahtt
reviewed
Sep 4, 2024
Gudahtt
suggested changes
Sep 4, 2024
Member
Gudahtt
left a comment
There was a problem hiding this comment.
One changelog lint error to fix
Gudahtt
approved these changes
Sep 4, 2024
Member
|
Gudahtt
added a commit
that referenced
this pull request
Sep 6, 2024
Gudahtt
added a commit
that referenced
this pull request
Oct 2, 2024
* Request validation should not throw if verifyingContract is not defined in typed signature (#328) (#330) * 14.0.1 (#331) * [14.x] fix: support ethermint's EIP712 implementation (#333) * setting cosmos as allowed string for verifyingContract field * fixed and linter * readability * Update condition to match main branch * Remove duplicate copy of test --------- Co-authored-by: Jyoti Puri <jyotipuri@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com> * Version 14.0.2 (#339) * Version 14.0.2 * Fix typo Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com> --------- Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com> --------- Co-authored-by: Jyoti Puri <jyotipuri@gmail.com> Co-authored-by: Michael Tsitrin <114929630+mtsitrin@users.noreply.github.com> Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.