adapt to eip-1193 provider changes#317
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/eth-block-tracker@10.0.0, npm/@metamask/eth-json-rpc-provider@4.0.0 |
legobeat
left a comment
There was a problem hiding this comment.
Hm, unit tests still failing?
https://github.com/MetaMask/eth-json-rpc-middleware/actions/runs/9975509645/job/27565450801?pr=317
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
mcmire
left a comment
There was a problem hiding this comment.
The overall approach here makes sense to me. Most of my comments below are minor.
|
@SocketSecurity ignore npm/@metamask/eth-block-tracker@10.1.0 This is our own package. |
mcmire
left a comment
There was a problem hiding this comment.
Had some suggestions, but overall, the approach makes sense.
|
@SocketSecurity ignore npm/@metamask/eth-block-tracker@11.0.0 This is our own package. |
After
SafeEventEmitterProvideris updated to support EIP-1193 and a new version of@metamask/eth-json-rpc-provideris released, we should adapt to the changes:@metamask/eth-json-rpc-providerto rely on the new changes.sendAsyncwill be deprecated; we should userequestinstead.sendAsync:retryOnEmptyandblock-ref.sendAsyncinproviderAsMiddleware.sendAsyncon the provider. The tests use a helper,stubProviderRequestswhich does this in particular. These references need to be changed.