Skip to content

v4.0.0#64

Merged
whymarrh merged 2 commits intomasterfrom
v4.0.0
Oct 20, 2020
Merged

v4.0.0#64
whymarrh merged 2 commits intomasterfrom
v4.0.0

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

@whymarrh whymarrh commented Aug 20, 2020 •
edited
Loading

Refs #46
Depends on #58, #62, #63

This PR represents the next major version, v4.

@whymarrh whymarrh mentioned this pull request Aug 31, 2020
Closed
3 tasks
@whymarrh whymarrh marked this pull request as ready for review October 20, 2020 15:28
@whymarrh whymarrh requested a review from a team as a code owner October 20, 2020 15:28
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Oct 20, 2020

In testing this on the extension, I noticed that the rule node/no-unsupported-features/es-syntax was showing errors for ES6 syntax. This seems contrary to what we want from this config 🤔

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Oct 20, 2020

Also, node/file-extension-in-import is currently requiring file extensions for import statements. Is this the default we want? We currently require the opposite - no file extensions.

@whymarrh
Copy link
Copy Markdown
Contributor Author

whymarrh commented Oct 20, 2020

Both good finds, thanks @Gudahtt!

@whymarrh
Copy link
Copy Markdown
Contributor Author

whymarrh commented Oct 20, 2020

I'll fix those!

This was referenced Oct 20, 2020
Merged
Merged
Gudahtt
Gudahtt requested changes Oct 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth mentioning #68 and #65 as well

Gudahtt
Gudahtt approved these changes Oct 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit a30c5c8 into master Oct 20, 2020
@whymarrh whymarrh deleted the v4.0.0 branch October 20, 2020 19:00
@whymarrh
Copy link
Copy Markdown
Contributor Author

whymarrh commented Oct 20, 2020

A new version of the package @metamask/eslint-config (4.0.0) was published at 2020-10-20T19:01:32.862Z from
[redacted]. The shasum of this package was 0c1461a49e6abc924baf23063d58050467d235dd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whymarrh @Gudahtt