Conversation
62023ed to
b1f7e66
Compare
b1f7e66 to
9f667a0
Compare
This change disables deprecated core Node.js/CommonJS rules in favour of rules from eslint-plugin-node. From the docs: [1] > The ten Node.js/CommonJS rules in core have been deprecated and moved to the eslint-plugin-node plugin. [1]:https://eslint.org/docs/user-guide/migrating-to-7.0.0#deprecate-node-rules All of the available eslint-plugin-node rules have been enabled.
9f667a0 to
6942063
Compare
Gudahtt
approved these changes
Oct 20, 2020
| 'node/no-process-env': 'error', | ||
| 'node/no-restricted-import': 'error', | ||
| 'node/no-restricted-require': 'error', | ||
| 'node/no-sync': 'error', |
Member
There was a problem hiding this comment.
This rule was previously disabled explicitly.
Member
There was a problem hiding this comment.
This also seems fine to enable.
| 'node/file-extension-in-import': 'error', | ||
| 'node/global-require': 'error', | ||
| 'node/no-mixed-requires': 'error', | ||
| 'node/no-process-env': 'error', |
Member
There was a problem hiding this comment.
This rule was previously disabled explicitly.
Member
There was a problem hiding this comment.
It seems fine to enable though 🤔 We can disable it in the extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #46
This change disables deprecated core Node.js/CommonJS rules in favour of rules from eslint-plugin-node.
From the docs:[1]
All of the available eslint-plugin-node rules have been enabled.