BREAKING: Replace eslint-plugin-import with eslint-plugin-import-x#356
Merged
BREAKING: Replace eslint-plugin-import with eslint-plugin-import-x#356
eslint-plugin-import with eslint-plugin-import-x#356Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
mcmire
approved these changes
Jun 4, 2024
Mrtenz
added a commit
that referenced
this pull request
Jun 4, 2024
#356) * Replace `eslint-plugin-import` with `eslint-plugin-import-x` * Update READMEs * Fix local ESLint config * Update lockfile
Mrtenz
added a commit
that referenced
this pull request
Aug 16, 2024
#356) * Replace `eslint-plugin-import` with `eslint-plugin-import-x` * Update READMEs * Fix local ESLint config * Update lockfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint-plugin-importhas a regression from versions>=2.27.0, meaning we had to pin it to2.26.x. It also has performance issues when importing large packages, such asprettierortypescript, and seems to use up the majority of the total time ESLint takes to run in most cases.eslint-plugin-import-xis a fork ofeslint-plugin-importand is mostly compatible (after replacingimport/withimport-x/in the configs). It has much better performance, and does not have the same regression aseslint-plugin-import@>=2.27.0.I'm already using
eslint-plugin-import-xin TS Bridge with some patches, and it's working great.Breaking changes
eslint-plugin-importand installeslint-plugin-import-xinstead.eslint-plugin-importwill need to be updated toeslint-plugin-import-x.