Skip to content

chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.1.0#146

Merged
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:devdeps-lavamoat-allow-scripts
Jul 26, 2024
Merged

chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.1.0#146
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:devdeps-lavamoat-allow-scripts

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented May 21, 2024

No description provided.

@socket-security
Copy link
Copy Markdown

socket-security bot commented May 21, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lavamoat/aa@4.3.0 None 0 20.1 kB lmbot
npm/@lavamoat/allow-scripts@3.1.0 environment 0 46.8 kB lmbot
npm/@npmcli/agent@2.2.2 environment, network 0 17.7 kB npm-cli-ops
npm/@npmcli/fs@3.1.1 filesystem 0 26.5 kB lukekarrys
npm/@npmcli/git@5.0.8 environment, filesystem 0 23 kB npm-cli-ops
npm/@npmcli/package-json@5.2.0 filesystem 0 39.5 kB npm-cli-ops
npm/@npmcli/promise-spawn@7.0.2 environment, shell 0 12.2 kB npm-cli-ops
npm/@npmcli/run-script@7.0.4 environment 0 18.4 kB npm-cli-ops
npm/abbrev@2.0.0 None 0 4.83 kB lukekarrys
npm/agent-base@7.1.1 network 0 31.2 kB tootallnate
npm/bin-links@4.0.4 filesystem 0 20.7 kB npm-cli-ops
npm/cacache@18.0.4 filesystem 0 63.7 kB npm-cli-ops
npm/exponential-backoff@3.1.1 None 0 37.3 kB sssayegh
npm/fs-minipass@3.0.3 filesystem 0 14.4 kB npm-cli-ops
npm/hosted-git-info@7.0.2 None 0 26.6 kB npm-cli-ops
npm/http-proxy-agent@7.0.2 network 0 23.3 kB tootallnate
npm/https-proxy-agent@7.0.5 network 0 34.9 kB tootallnate
npm/ini@4.1.3 None 0 12.1 kB npm-cli-ops
npm/ip-address@9.0.5 None 0 177 kB beaugunderson
npm/jsbn@1.1.0 None 0 46.9 kB andyperlitch
npm/lru-cache@5.1.1 None 0 15.7 kB isaacs
npm/make-fetch-happen@13.0.1 network 0 52.8 kB npm-cli-ops
npm/minipass-collect@2.0.1 None 0 4.96 kB isaacs
npm/minipass-fetch@3.0.5 environment, network 0 46.8 kB npm-cli-ops
npm/minipass@7.1.2 None 0 286 kB isaacs
npm/node-gyp@10.2.0 environment, shell 0 1.85 MB nodejs-foundation
npm/nopt@7.2.1 None 0 26.2 kB npm-cli-ops
npm/normalize-package-data@6.0.2 None 0 28.2 kB npm-cli-ops
npm/npm-install-checks@6.3.0 None 0 6.21 kB npm-cli-ops
npm/npm-normalize-package-bin@3.0.1 None 0 3.58 kB npm-cli-ops
npm/npm-package-arg@11.0.3 None 0 19.2 kB npm-cli-ops
npm/npm-pick-manifest@9.1.0 None 0 16.5 kB npm-cli-ops
npm/proc-log@4.2.0 None 0 12.3 kB npm-cli-ops
npm/semver@7.6.3 None 0 95.8 kB npm-cli-ops
npm/socks-proxy-agent@8.0.4 network 0 24.8 kB tootallnate
npm/socks@2.8.3 network 0 156 kB joshglazebrook
npm/spdx-correct@3.2.0 None 0 23.4 kB kemitchell
npm/sprintf-js@1.1.3 None 0 39.9 kB alexei
npm/ssri@10.0.6 None 0 38.7 kB npm-cli-ops
npm/unique-filename@3.0.0 None 0 3.41 kB lukekarrys
npm/unique-slug@4.0.0 None 0 2.58 kB lukekarrys
npm/validate-npm-package-license@3.0.4 None 0 16.6 kB kemitchell
npm/validate-npm-package-name@5.0.1 unsafe 0 7.77 kB npm-cli-ops
npm/yallist@3.1.1 None 0 14.8 kB isaacs

🚮 Removed packages: npm/@gar/promisify@1.1.3, npm/@lavamoat/aa@3.1.2, npm/@lavamoat/allow-scripts@2.3.1, npm/@npmcli/fs@2.1.0, npm/@npmcli/move-file@2.0.0, npm/@npmcli/promise-spawn@6.0.2, npm/@npmcli/run-script@6.0.0, npm/@tootallnate/once@2.0.0, npm/abbrev@1.1.1, npm/agent-base@6.0.2, npm/agentkeepalive@4.2.1, npm/aproba@2.0.0, npm/are-we-there-yet@3.0.0, npm/bin-links@4.0.1, npm/cacache@16.1.1, npm/color-support@1.1.3, npm/console-control-strings@1.1.0, npm/delegates@1.0.0, npm/depd@1.1.2, npm/fs-minipass@2.1.0, npm/gauge@4.0.4, npm/has-unicode@2.0.1, npm/http-proxy-agent@5.0.0, npm/https-proxy-agent@5.0.1, npm/humanize-ms@1.2.1, npm/infer-owner@1.0.4, npm/ip@1.1.8, npm/lru-cache@6.0.0, npm/make-fetch-happen@10.1.8, npm/minipass-collect@1.0.2, npm/minipass-fetch@2.1.0, npm/minipass@3.3.4, npm/node-gyp@9.3.1, npm/nopt@6.0.0, npm/npm-normalize-package-bin@3.0.0, npm/npmlog@6.0.2, npm/read-package-json-fast@3.0.2, npm/readable-stream@3.6.0, npm/safe-buffer@5.2.1, npm/semver@7.5.4, npm/set-blocking@2.0.0, npm/socks-proxy-agent@7.0.0, npm/socks@2.6.2, npm/sprintf-js@1.0.3, npm/ssri@9.0.1, npm/string_decoder@1.3.0, npm/unique-filename@1.1.1, npm/unique-slug@2.0.2, npm/util-deprecate@1.0.2, npm/wide-align@1.1.5, npm/yallist@4.0.0

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented May 21, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
New author npm/npm-normalize-package-bin@3.0.1 🚫
New author npm/abbrev@2.0.0 🚫
New author npm/exponential-backoff@3.1.1 🚫
Network access npm/agent-base@7.1.1 🚫
Network access npm/agent-base@7.1.1 🚫
Network access npm/agent-base@7.1.1 🚫
Network access npm/@npmcli/agent@2.2.2 🚫
Network access npm/@npmcli/agent@2.2.2 🚫
Network access npm/@npmcli/agent@2.2.2 🚫
Network access npm/@npmcli/agent@2.2.2 🚫
Network access npm/@npmcli/agent@2.2.2 🚫
New author npm/validate-npm-package-name@5.0.1 🚫
New author npm/node-gyp@10.2.0 🚫
Unstable ownership npm/@lavamoat/aa@4.3.0 🚫
New author npm/@lavamoat/aa@4.3.0 🚫
New author npm/@lavamoat/allow-scripts@3.1.0 🚫
Unstable ownership npm/@lavamoat/allow-scripts@3.1.0 🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/npm-normalize-package-bin@3.0.1
  • @SocketSecurity ignore npm/abbrev@2.0.0
  • @SocketSecurity ignore npm/exponential-backoff@3.1.1
  • @SocketSecurity ignore npm/agent-base@7.1.1
  • @SocketSecurity ignore npm/@npmcli/agent@2.2.2
  • @SocketSecurity ignore npm/validate-npm-package-name@5.0.1
  • @SocketSecurity ignore npm/node-gyp@10.2.0
  • @SocketSecurity ignore npm/@lavamoat/aa@4.3.0
  • @SocketSecurity ignore npm/@lavamoat/allow-scripts@3.1.0

@legobeat legobeat marked this pull request as ready for review May 21, 2024 04:47
@legobeat legobeat requested a review from a team as a code owner May 21, 2024 04:47
@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 21, 2024
mcmire
mcmire previously approved these changes Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing, this LGTM.

@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from 63163b6 to 6385152 Compare July 26, 2024 20:35
@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Jul 26, 2024

Sorry for the delay in reviewing, this LGTM.

All good! Will need another round though (merge-conflict resolution in yarn.lock). Also bumped to latest 3.1.0.

@legobeat legobeat changed the title chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.0.4 chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.1.0 Jul 26, 2024
@legobeat legobeat merged commit 4fa46bf into MetaMask:main Jul 26, 2024
Gudahtt added a commit that referenced this pull request Nov 1, 2024
@Gudahtt
Merge remote-tracking branch 'origin/main' into v3.x
5d37d08 
* origin/main:
  feat: allow `npm:name@version` dependency redirections in manifest (#158)
  4.0.0 (#157)
  BREAKING: Bump `@metamask/auto-changelog` to `^4.0.0`, and bump related dependencies (#156)
  chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.1.0 (#146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@mcmire mcmire mcmire left review comments

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat @mcmire @cryptodev-2s