Skip to content

Feature: collectibles api key#95

Merged
estebanmino merged 3 commits intomasterfrom
feature/collectible-api-key
Apr 11, 2019
Merged

Feature: collectibles api key#95
estebanmino merged 3 commits intomasterfrom
feature/collectible-api-key

Conversation

@estebanmino
Copy link
Copy Markdown
Contributor

This PR adds the ability to set an API key to be used with OpenSea. If it's not set, it will default to the open api endpoint.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 11, 2019

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines        1387   1393    +6     
  Branches      176    179    +3     
=====================================
+ Hits         1387   1393    +6
Impacted Files Coverage Δ
src/AssetsDetectionController.ts 100% <100%> (ø) ⬆️
src/AssetsController.ts 100% <100%> (ø) ⬆️
src/util.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01cdec...340e6f0. Read the comment docs.

Copy link
Copy Markdown
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@estebanmino estebanmino merged commit 56c2939 into master Apr 11, 2019
@estebanmino estebanmino deleted the feature/collectible-api-key branch April 11, 2019 19:33
mcmire pushed a commit to mcmire/core that referenced this pull request Jul 17, 2023
The GitHub Actions have been updated to match the latest version of the
module template.

Notable changes include:
* We now use `setup-node` for caching rather than manually caching
dependencies.
* The "all-jobs-pass" required status check has been split into two
steps ("all-jobs-completed" and "all-jobs-pass") to ensure it runs even
when a required job is skipped, ensuring that the status check itself
is never skipped.
* The obsolete `require-additional-reviewer` check has been removed.
* Yarn v3 is now used for publishing rather than npm
kanthesha pushed a commit that referenced this pull request Oct 11, 2023
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* ability to add api key

* test

* doc
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* ability to add api key

* test

* doc
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)

---
updated-dependencies:
- dependency-name: glob-parent
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants