feat: implement rich notification setting config using AUS#8784
Merged
baptiste-marchand merged 16 commits intoMay 13, 2026
Conversation
…notification flags
…flag and improve wallet activity account handling
a279ae9 to
ab7bf53
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b01857c. Configure here.
oilnam
approved these changes
May 13, 2026
dovydas55
approved these changes
May 13, 2026
10 tasks
pull Bot
pushed a commit
to Dustin4444/metamask-mobile
that referenced
this pull request
May 20, 2026
…30106) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Revamps the notifications settings UX into section-based configuration (wallet activity, perps, Social AI, marketing) with a new NotificationSettingsSection screen and updated navigators to route into it. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Revamp notification settings and enrich them with several sections ## **Related issues** Core PR: MetaMask/core#8784 Fixes: https://consensyssoftware.atlassian.net/browse/GE-13 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/9171d271-dd41-4c5d-acfe-c081d8a383dd https://github.com/user-attachments/assets/b28bfcec-631d-469f-b4f4-394731944fb2 ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Moderate risk: refactors notifications settings/navigation and introduces new AUS-backed preference read/merge/write logic, which could affect persistence and toggle behavior if the storage contract or caching assumptions are wrong. > > **Overview** > Revamps notification settings into a **section-based UI** (wallet activity, perps, Social AI, marketing) with a new `NotificationSettingsSection` screen for per-section push/in-app toggles and extra content (wallet-activity account selection + marketing disclaimer + embedded Social AI preferences). > > Switches preference sourcing/persistence to **Authenticated User Storage (AUS)** via a new `useNotificationStoragePreferences` hook (shared query key, optimistic cache updates, read-merge-write PUT, and refetch-on-failure), and updates Social AI preferences to reuse this shared storage flow. > > Updates navigation and headers to support the new section route (`Routes.SETTINGS.NOTIFICATION_SETTINGS_SECTION`), modernizes the notifications list header UI, and removes legacy/developer-only pieces (e.g., `resetNotifications`, `SettingsNotification`, and the Social Leaderboard `NotificationPreferencesView`) while adjusting tests accordingly. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit afee7a6. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
This PR updates notification preferences to use AUS as the source of truth after first initialization, in order to enrich notification settings with the following categories:
For new users, the NotificationServicesController now writes a complete preferences blob, seeding wallet activity from the current Trigger API state and defaulting all current accounts to enabled for true first-time setup. Marketing initialization is split by channel: push follows marketing consent, while in-app follows the product announcement current option.
References
Fixes GE-13
Checklist
Note
Medium Risk
Changes the notification settings source of truth and initialization/write paths (Trigger API -> AUS), which can affect user notification enablement and push registration behavior across accounts and channels.
Overview
Moves notification preference storage to Authenticated User Storage (AUS).
NotificationServicesControllernow reads/writes notification preferences via AUS messenger actions and uses those preferences (instead of Trigger API config) when enabling push notifications, checking account presence, and selecting addresses for fetching on-chain notifications.Adds first-time preference initialization and new options. When AUS has no preferences (
null),createOnChainTriggerswrites a complete preferences blob (wallet activity seeded from current Trigger API state with first-time “enable all” fallback, plus default Perps/SocialAI) and seeds marketing push/in-app from newhasMarketingConsentandproductAnnouncementEnabledoptions; the oldresetNotificationsoption is removed.Updates shared types and tests.
@metamask/authenticated-user-storagenotification preference types/validators replaceenabledwith per-channelinAppNotificationsEnabled/pushNotificationsEnabled, and notification-services-controller tests/mocks are rewritten to mock AUS calls and dropupdateOnChainNotificationscoverage.Reviewed by Cursor Bugbot for commit c1c039d. Bugbot is set up for automated code reviews on this repo. Configure here.