Merged
Conversation
72dfcb0 to
e46497e
Compare
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 1334 1356 +22
Branches 166 174 +8
=====================================
+ Hits 1334 1356 +22
Continue to review full report at Codecov.
|
estebanmino
reviewed
Apr 4, 2019
estebanmino
reviewed
Apr 4, 2019
estebanmino
reviewed
Apr 4, 2019
estebanmino
reviewed
Apr 4, 2019
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Enforcing minimum node version 12 via .nvmrc, circleci, and the package file * Adding a note about running tests to README.md * Adding basic .gitattributes file
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* keep track of removed tokens * check array length before proceeding * check ignore list only on detection * added tests * added methods to clear ignore list * clean up * Fix type * Fix type * Check for ignoredTokens * Remove unnecessary checks * prevent duplicates in ignore list * fix cov * fix coverage
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* keep track of removed tokens * check array length before proceeding * check ignore list only on detection * added tests * added methods to clear ignore list * clean up * Fix type * Fix type * Check for ignoredTokens * Remove unnecessary checks * prevent duplicates in ignore list * fix cov * fix coverage
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Bumps [tar](https://github.com/npm/node-tar) from 4.4.8 to 4.4.17. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v4.4.8...v4.4.17) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent assets to be "re-detected" after being removed, we need to keep them in state.
I've implemented that by adding two additional arrays to the AssetDetection controller to keep track of removed collectibles and assets.
Also added to additional methods to manually clear those lists if required