feat: add MegaEth Testnet as default network#5506
Merged
stanleyyconsensys merged 7 commits intomainfrom Mar 21, 2025
Merged
Conversation
MegaEth Testnet to network controller
MegaEth Testnet to network controllerMegaEth Testnet to network-controller
Contributor
|
@metamaskbot publish-preview that one is for 22.2 |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mcmire
previously approved these changes
Mar 20, 2025
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Nice, good job! I just had two questions but they are non-blocking.
mcmire
previously approved these changes
Mar 20, 2025
fd5ef93 to
a47985c
Compare
Contributor
|
@metamaskbot publish-preview that one is based on 23 |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
MegaEth Testnet to network-controllerMegaEth Testnet as default network
Prithpal-Sooriya
approved these changes
Mar 21, 2025
mcmire
approved these changes
Mar 21, 2025
Merged
matthewwalsh0
approved these changes
Mar 21, 2025
- fix mock network hardcoded mock path when RPC has endpoint with '/rpc' - fix test result on token detection when megaETH network added as default
2fd5d05 to
c49760a
Compare
wantedsystem
added a commit
that referenced
this pull request
Mar 21, 2025
This reverts commit e323f71.
wantedsystem
added a commit
that referenced
this pull request
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Further to Previous PR: #5495
We are adding MegaETH Testnet as default network on
Network Controllerdefault state -networkConfigurationsByChainIdwith the constants and type from the latestcontroller-utilsWhich enable adding MegaETH Testnet as a default network on Mobile / Extension
Changes:
getDefaultInfuraNetworkConfigurationsByChainIdandgetDefaultCustomNetworkConfigurationsByChainIdmock-networknot support a use case when the RPC endpoint come with a path segment, e.g: 'https://carrot.megaeth.com/rpc'MegaETH TestnetChainId into constantsCHAIN_IDSfromtransaction-controllerNote :
For everyone interested in testing this version in MM mobile you can use this branch to do so : https://github.com/MetaMask/metamask-mobile/tree/feat/add-megaeth-testnet
References
Changelog
@metamask/network-controller@metamask/transaction-controllerMegaETH TestnetChainId into constantsCHAIN_IDSChecklist