Skip to content

Update createServicePolicy to expose sub-policies; add re-exports from cockatiel#5192

Merged
mcmire merged 2 commits intomainfrom
add-conveniences-to-create-service-policy
Jan 24, 2025
Merged

Update createServicePolicy to expose sub-policies; add re-exports from cockatiel#5192
mcmire merged 2 commits intomainfrom
add-conveniences-to-create-service-policy

Conversation

@mcmire
Copy link
Copy Markdown
Contributor

@mcmire mcmire commented Jan 23, 2025

Explanation

Expose these exports from cockatiel so consumers can use them without needing to depend on the library directly:

  • BrokenCircuitError
  • CircuitState
  • handleAll
  • handleWhen

Also, update createServicePolicy to expose the retry and circuit breaker policies so that we can access their state in other modules that use this utility function.

This is needed to be able to create an RPC service.

References

Progresses #4994.
Pre-requisite to #4990.

Changelog

(Updated in changelog.)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mcmire mcmire force-pushed the add-conveniences-to-create-service-policy branch from 95400dc to 53b5f94 Compare January 23, 2025 20:15
Base automatically changed from convert-callbacks-to-methods to main January 23, 2025 23:00
Expose these exports from `cockatiel` so consumers can use them without
needing to depend on the library directly:

- `BrokenCircuitError`
- `CircuitState`
- `handleAll`
- `handleWhen`

Also, update `createServicePolicy` to expose the retry and circuit
breaker policies so that we can access their state in other modules that
use this utility function.

This is needed to be able to create an RPC service.
@mcmire mcmire force-pushed the add-conveniences-to-create-service-policy branch from 53b5f94 to f63c3d3 Compare January 24, 2025 00:10
@mcmire mcmire changed the title Add conveniences to createServicePolicy Update createServicePolicy to expose sub-policies; add re-exports from cockatiel Jan 24, 2025
@mcmire mcmire marked this pull request as ready for review January 24, 2025 00:16
@mcmire mcmire requested a review from a team as a code owner January 24, 2025 00:16
@mcmire mcmire added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label Jan 24, 2025
@mcmire mcmire merged commit 763f06f into main Jan 24, 2025
@mcmire mcmire deleted the add-conveniences-to-create-service-policy branch January 24, 2025 00:31
zone-live pushed a commit that referenced this pull request Jan 27, 2025
…rom `cockatiel` (#5192)

Expose these exports from `cockatiel` so consumers can use them without
needing to depend on the library directly:

- `BrokenCircuitError`
- `CircuitState`
- `handleAll`
- `handleWhen`

Also, update `createServicePolicy` to expose the retry and circuit
breaker policies so that we can access their state in other modules that
use this utility function.

This is needed to be able to create an RPC service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-wallet-framework Deprecated: Please use `team-core-platform` instead.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants