Skip to content

fix: issue where QueuedRequestController.state.queuedRequestCount is not updated after flushing requests for an origin#4898

Merged
adonesky1 merged 2 commits intomainfrom
ad/fix-queueing-bug
Nov 6, 2024
Merged

fix: issue where QueuedRequestController.state.queuedRequestCount is not updated after flushing requests for an origin#4898
adonesky1 merged 2 commits intomainfrom
ad/fix-queueing-bug

Conversation

@adonesky1
Copy link
Copy Markdown
Contributor

@adonesky1 adonesky1 commented Nov 6, 2024 •
edited
Loading

Explanation

Fix issue where QueuedRequestController.state.queuedRequestCount is not updated after flushing requests for an origin

References

Fixes

Before

https://drive.google.com/file/d/1ujdQgVLlT8KlwRwO-Cc3XvRHPrkpxIg_/view?usp=drive_link

After

Screen.Recording.2024-11-06.at.3.41.05.PM.mov

Changelog

@metamask/queued-request-controller

  • FIX: Ensure queuedRequestCount value is updated properly after flushing the queue for a given origin

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@adonesky1 adonesky1 requested a review from a team as a code owner November 6, 2024 21:21
@adonesky1
Copy link
Copy Markdown
Contributor Author

adonesky1 commented Nov 6, 2024

@metamaskbot publish-preview

@adonesky1 adonesky1 changed the title fix issue where state.queuedRequestCount is not updated after flushing requests for an origin fix issue where QueuedRequestController.state.queuedRequestCount is not updated after flushing requests for an origin Nov 6, 2024
@adonesky1 adonesky1 changed the title fix issue where QueuedRequestController.state.queuedRequestCount is not updated after flushing requests for an origin fix: issue where QueuedRequestController.state.queuedRequestCount is not updated after flushing requests for an origin Nov 6, 2024
@adonesky1
Copy link
Copy Markdown
Contributor Author

adonesky1 commented Nov 6, 2024

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 6, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.2.3-preview-66b0cbe",
  "@metamask-previews/address-book-controller": "6.0.1-preview-66b0cbe",
  "@metamask-previews/announcement-controller": "7.0.1-preview-66b0cbe",
  "@metamask-previews/approval-controller": "7.1.1-preview-66b0cbe",
  "@metamask-previews/assets-controllers": "42.0.0-preview-66b0cbe",
  "@metamask-previews/base-controller": "7.0.2-preview-66b0cbe",
  "@metamask-previews/build-utils": "3.0.1-preview-66b0cbe",
  "@metamask-previews/chain-controller": "0.1.3-preview-66b0cbe",
  "@metamask-previews/composable-controller": "9.0.1-preview-66b0cbe",
  "@metamask-previews/controller-utils": "11.4.2-preview-66b0cbe",
  "@metamask-previews/ens-controller": "15.0.0-preview-66b0cbe",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-66b0cbe",
  "@metamask-previews/gas-fee-controller": "22.0.0-preview-66b0cbe",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-66b0cbe",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-66b0cbe",
  "@metamask-previews/keyring-controller": "17.3.1-preview-66b0cbe",
  "@metamask-previews/logging-controller": "6.0.1-preview-66b0cbe",
  "@metamask-previews/message-manager": "11.0.1-preview-66b0cbe",
  "@metamask-previews/multichain": "0.0.0-preview-66b0cbe",
  "@metamask-previews/name-controller": "8.0.1-preview-66b0cbe",
  "@metamask-previews/network-controller": "22.0.1-preview-66b0cbe",
  "@metamask-previews/notification-controller": "7.0.0-preview-66b0cbe",
  "@metamask-previews/notification-services-controller": "0.12.1-preview-66b0cbe",
  "@metamask-previews/permission-controller": "11.0.3-preview-66b0cbe",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-66b0cbe",
  "@metamask-previews/phishing-controller": "12.3.0-preview-66b0cbe",
  "@metamask-previews/polling-controller": "12.0.1-preview-66b0cbe",
  "@metamask-previews/preferences-controller": "13.2.0-preview-66b0cbe",
  "@metamask-previews/profile-sync-controller": "0.9.7-preview-66b0cbe",
  "@metamask-previews/queued-request-controller": "7.0.0-preview-66b0cbe",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-66b0cbe",
  "@metamask-previews/selected-network-controller": "19.0.0-preview-66b0cbe",
  "@metamask-previews/signature-controller": "21.0.0-preview-66b0cbe",
  "@metamask-previews/transaction-controller": "38.2.0-preview-66b0cbe",
  "@metamask-previews/user-operation-controller": "17.0.0-preview-66b0cbe"
}

@adonesky1 adonesky1 requested review from Gudahtt and mcmire November 6, 2024 22:04
mcmire
mcmire approved these changes Nov 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@adonesky1 adonesky1 enabled auto-merge (squash) November 6, 2024 22:13
Gudahtt
Gudahtt approved these changes Nov 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit 340f183 into main Nov 6, 2024
@adonesky1 adonesky1 deleted the ad/fix-queueing-bug branch November 6, 2024 22:18
@adonesky1 adonesky1 mentioned this pull request Nov 6, 2024
Merged
adonesky1 added a commit that referenced this pull request Nov 7, 2024
@adonesky1
Release/240.0.0 (#4899)
99b320b 
## Changelog

### @metamask/queued-request-controller

## [7.0.1]

### Fixed

- Fix issue where `queuedRequestCount` state is not updated after
flushing requests for an origin
([#4898](#4898))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmire mcmire mcmire approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adonesky1 @mcmire @Gudahtt