Skip to content

Use Node 12#441

Merged
rekmarks merged 2 commits intodevelopfrom
bump-node-version
Apr 13, 2021
Merged

Use Node 12#441
rekmarks merged 2 commits intodevelopfrom
bump-node-version

Conversation

@rekmarks
Copy link
Copy Markdown
Member

We're bumping to Node 12 all over the place due to Node 10 reaching EOL, and this should be no exception.

@rekmarks rekmarks requested a review from a team as a code owner April 13, 2021 15:46
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Apr 13, 2021

Maybe worth adding an engines field as well? We've done so everywhere else

@rekmarks
Copy link
Copy Markdown
Member Author

Ah, done!

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit c575bb3 into develop Apr 13, 2021
@rekmarks rekmarks deleted the bump-node-version branch April 13, 2021 16:17
Gudahtt added a commit that referenced this pull request Apr 15, 2021
- Add restricted controller messenger ([#378](#378))

- **BREAKING:** Update minimum Node.js version to v12 ([#441](#441))
- **BREAKING:** Replace controller context ([#387](#387))
- Bump @metamask/contract-metadata from 1.23.0 to 1.24.0 ([#440](#440))
- Update lint rules ([#442](#442), [#426](#426))

- Don't remove collectibles during auto detection ([#439](#439))
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Use Node 12

* Add engines field
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Use Node 12

* Add engines field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants