Support longer token symbols via wallet_watchAsset#433
Merged
Conversation
This increases the maximum token length that can be suggested via `watchAsset` from 6 to 11, which matches the maximum symbol length for custom tokens added on the MetaMask extension.
watchAssetwallet_watchAsset
ryanml
reviewed
Mar 24, 2021
The minimum and maximum token symbol lengths are now tested, as is the failure case where the token symbol is an empty string.
ryanml
approved these changes
Mar 24, 2021
Contributor
ryanml
left a comment
There was a problem hiding this comment.
++ thanks for the changes!
Member
Author
|
Thanks for the reviews! Marking this as "DO-NOT-MERGE" for now until the mobile team has signed off on this. |
Member
Author
|
Removing the |
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Support longer token symbols via `watchAsset` This increases the maximum token length that can be suggested via `watchAsset` from 6 to 11, which matches the maximum symbol length for custom tokens added on the MetaMask extension. * Add additional tests for symbol length boundary conditions The minimum and maximum token symbol lengths are now tested, as is the failure case where the token symbol is an empty string.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Support longer token symbols via `watchAsset` This increases the maximum token length that can be suggested via `watchAsset` from 6 to 11, which matches the maximum symbol length for custom tokens added on the MetaMask extension. * Add additional tests for symbol length boundary conditions The minimum and maximum token symbol lengths are now tested, as is the failure case where the token symbol is an empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increases the maximum token length that can be suggested via
wallet_watchAssetfrom 6 to 11, which matches the maximum symbol length for custom tokens added on the MetaMask extension.