Skip to content

Add messages to empty tothrow calls#422

Merged
astarinmymind merged 2 commits intodevelopfrom
remove-jest-require-tothrow-message
Mar 20, 2021
Merged

Add messages to empty tothrow calls#422
astarinmymind merged 2 commits intodevelopfrom
remove-jest-require-tothrow-message

Conversation

@astarinmymind
Copy link
Copy Markdown
Contributor

This PR aims to remove the eslint exception involving empty tothrow messages by replacing .tothrow() calls with .tothrow('error message').

@astarinmymind astarinmymind requested a review from a team as a code owner March 20, 2021 05:38
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astarinmymind astarinmymind merged commit f6699b1 into develop Mar 20, 2021
@astarinmymind astarinmymind deleted the remove-jest-require-tothrow-message branch March 20, 2021 16:10
Gudahtt added a commit that referenced this pull request Mar 22, 2021
This requirement was added recently in #422
Gudahtt added a commit that referenced this pull request Mar 22, 2021
This requirement was added recently in #422
Gudahtt added a commit that referenced this pull request Mar 23, 2021
This requirement was added recently in #422
Gudahtt added a commit that referenced this pull request Apr 7, 2021
This requirement was added recently in #422
Gudahtt added a commit that referenced this pull request Apr 13, 2021
This requirement was added recently in #422
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?

Are there any issues or other links reviewers should consult to
understand this pull request better? For instance:

* Fixes #12345
* See: #67890
-->

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Bumps `@metamask/eth-block-tracker` to `^12.2.1` and updates the
Unreleased changelog accordingly.
> 
> - **Dependencies**:
> - Bump `@metamask/eth-block-tracker` from `^12.2.0` to `^12.2.1` in
`package.json` and `yarn.lock`.
> - **Docs**:
> - Update `CHANGELOG.md` Unreleased with a Changed entry noting the
bump; retains the recent Fixed note on request processing delays.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
2d440aa394f26e0211c77d00e4ed617a7775c61e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants