Skip to content

Import async-mutex using import#401

Merged
Gudahtt merged 1 commit intodevelopfrom
import-async-mutex
Mar 16, 2021
Merged

Import async-mutex using import#401
Gudahtt merged 1 commit intodevelopfrom
import-async-mutex

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Mar 16, 2021

async-mutex is now imported using import rather than require. This ensures that TypeScript is type checking our usage of the module, rather than typing it as any.

No other changes were required.

@Gudahtt Gudahtt requested a review from a team as a code owner March 16, 2021 15:15
brad-decker
brad-decker previously approved these changes Mar 16, 2021
Copy link
Copy Markdown
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NiranjanaBinoy
NiranjanaBinoy previously approved these changes Mar 16, 2021
Copy link
Copy Markdown
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

`async-mutex` is now imported using `import` rather than `require`.
This ensures that TypeScript is type checking our usage of the module,
rather than typing it as `any`.

No other changes were required.
@Gudahtt Gudahtt dismissed stale reviews from NiranjanaBinoy and brad-decker via 80991d4 March 16, 2021 19:14
@Gudahtt Gudahtt force-pushed the import-async-mutex branch from f0fd0c2 to 80991d4 Compare March 16, 2021 19:14
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Mar 16, 2021

This has been rebased to resolve conflcits

@Gudahtt Gudahtt merged commit 2106f7a into develop Mar 16, 2021
@Gudahtt Gudahtt deleted the import-async-mutex branch March 16, 2021 20:14
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
`async-mutex` is now imported using `import` rather than `require`.
This ensures that TypeScript is type checking our usage of the module,
rather than typing it as `any`.

No other changes were required.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
`async-mutex` is now imported using `import` rather than `require`.
This ensures that TypeScript is type checking our usage of the module,
rather than typing it as `any`.

No other changes were required.
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
…) package (#401)

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?

Are there any issues or other links reviewers should consult to
understand this pull request better? For instance:

* Fixes #12345
* See: #67890
-->

## Explanation

The newly created EIP-5792 Middleware package ([PR
#6422](#6422)) currently contains
only the hooks required for the existing wallet middleware. To align
with the intended abstraction and reduce the monolithic nature of
wallet-middleware, we should fully extract the relevant middleware logic
from eth-json-rpc-middleware ([GitHub -
MetaMask/eth-json-rpc-middleware: Ethereum middleware for composing an
Ethereum provider using json-rpc-engine. Intended to replace
provider-engine](https://github.com/MetaMask/eth-json-rpc-middleware))
into this new package.

This PR removes the identified middleware into
@metamask/eip-5792-middleware.

PR [#6477](#6477) from
https://github.com/MetaMask/core moves this middleware to the specified
package.

* Fixes https://consensyssoftware.atlassian.net/browse/WAPI-691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants