fix(22139): add header to requests going to CoinGecko#3619
Closed
DDDDDanica wants to merge 1 commit intomainfrom
Closed
fix(22139): add header to requests going to CoinGecko#3619DDDDDanica wants to merge 1 commit intomainfrom
DDDDDanica wants to merge 1 commit intomainfrom
Conversation
b376d1c to
60fef47
Compare
adonesky1
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Dec 6, 2023
Bumps `@metamask/assets-controller` to v20.0.0. Adds `getNetworkClientById` callback to `TokenRatesController` constructor to [address only breaking change](https://github.com/MetaMask/core/blob/9238108438e61dcae39ec8a02d1a15aa540da4c4/packages/assets-controllers/CHANGELOG.md?plain=1#L14) This overwrites and deletes a patch that was added on top of `@metamask/assets-controllers` version 19.0.0. This was added for the 11.7.0 extension release but can be removed now and will be added back later via MetaMask/core#3619 (cc @DDDDDanica @Gudahtt)
Contributor
|
Hi @DDDDDanica! We've completely removed the CoinGecko code from this controller here: #3600 |
danjm
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Dec 20, 2023
Bumps `@metamask/assets-controller` to v20.0.0. Adds `getNetworkClientById` callback to `TokenRatesController` constructor to [address only breaking change](https://github.com/MetaMask/core/blob/9238108438e61dcae39ec8a02d1a15aa540da4c4/packages/assets-controllers/CHANGELOG.md?plain=1#L14) This overwrites and deletes a patch that was added on top of `@metamask/assets-controllers` version 19.0.0. This was added for the 11.7.0 extension release but can be removed now and will be added back later via MetaMask/core#3619 (cc @DDDDDanica @Gudahtt)
danjm
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Dec 22, 2023
Bumps `@metamask/assets-controller` to v20.0.0. Adds `getNetworkClientById` callback to `TokenRatesController` constructor to [address only breaking change](https://github.com/MetaMask/core/blob/9238108438e61dcae39ec8a02d1a15aa540da4c4/packages/assets-controllers/CHANGELOG.md?plain=1#L14) This overwrites and deletes a patch that was added on top of `@metamask/assets-controllers` version 19.0.0. This was added for the 11.7.0 extension release but can be removed now and will be added back later via MetaMask/core#3619 (cc @DDDDDanica @Gudahtt)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add a header to CoinGecko related requests to help with api abuse and give a buffer time for replacing with our own pricing api.
References
Changelog
@metamask/assets-controllersChecklist