Skip to content

Use jsDelivr instead of the GitHub API for content#256

Merged
whymarrh merged 2 commits intoMetaMask:developfrom
whymarrh:update-phishing-config-url
Aug 18, 2020
Merged

Use jsDelivr instead of the GitHub API for content#256
whymarrh merged 2 commits intoMetaMask:developfrom
whymarrh:update-phishing-config-url

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

@whymarrh whymarrh commented Aug 18, 2020

Refs #219

At the request of GitHub, this change updates how we query for the latest blocklist content. We now hit jsDelivr instead of the GitHub API.

@whymarrh
Use jsDelivr instead of the GitHub API for content
61eb72c 
Refs MetaMask#219

At the request of GitHub, this change updates how we query for the latest
blocklist content. We now hit [jsDelivr][1] instead of the GitHub API.

  [1]:https://www.jsdelivr.com
@whymarrh whymarrh requested a review from a team as a code owner August 18, 2020 21:34
Gudahtt
Gudahtt approved these changes Aug 18, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh
Copy link
Copy Markdown
Contributor Author

whymarrh commented Aug 18, 2020

Note their Acceptable Use Policy.

I think esp. with #257 that we aren't in violation of their policy:

✅ Any content accessed via jsDelivr must conform to the terms of the service from which it was retrieved
✅ As long as you do not violate our rules [...] there are no limits on bandwidth or number of requests
✅ We don't exceed any of their hard limits
✅ For projects using our GitHub proxy [...] the number of actively accessed files per repository does not exceed 10,000

Their listed prohibited uses:

  1. Abusing the service and its resources, or using jsDelivr as a general-purpose
    file or media hosting service. This includes, for example:

    • running an image hosting website and using jsDelivr as a storage for all
      uploaded images,
    • hosting videos, file backups, or other files in large quantities.

    We recognize that there are legitimate projects that consist of a large number
    of files, and these are not considered abuse. For example: icons packs, apps,
    or games with a large number of assets.

  2. Trying to bypass our limits or restrictions in any way. We will be happy
    to remove limits or provide custom solutions for legitimate projects.

I don't think any of that applies here. This isn't general-purpose file-hosting.

@whymarrh whymarrh merged commit bcc494c into MetaMask:develop Aug 18, 2020
@whymarrh whymarrh deleted the update-phishing-config-url branch August 18, 2020 21:58
This was referenced Aug 18, 2020
Merged
Merged
@whymarrh whymarrh mentioned this pull request Sep 15, 2020
Merged
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@whymarrh @MajorLift
Use jsDelivr instead of the GitHub API for content (#256)
4827147 
Refs #219

At the request of GitHub, this change updates how we query for the latest
blocklist content. We now hit [jsDelivr][1] instead of the GitHub API.

  [1]:https://www.jsdelivr.com
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@whymarrh @MajorLift
Use jsDelivr instead of the GitHub API for content (#256)
588bdc4 
Refs #219

At the request of GitHub, this change updates how we query for the latest
blocklist content. We now hit [jsDelivr][1] instead of the GitHub API.

  [1]:https://www.jsdelivr.com
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
@dependabot
Bump @metamask/json-rpc-engine from 7.1.1 to 7.2.0 (#256)
f57ef8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whymarrh @Gudahtt