Skip to content

Use package-lock#192

Merged
rekmarks merged 2 commits intodevelopfrom
no-shrinkwrap
Jan 24, 2020
Merged

Use package-lock#192
rekmarks merged 2 commits intodevelopfrom
no-shrinkwrap

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Jan 22, 2020 •
edited
Loading

  • Rename npm-shrinkwrap.json to package-lock.json
  • Update .nvmrc: 10.16.0 -> 10.17.0
  • Remove npm-shrinkwrap from .editorconfig

@rekmarks rekmarks mentioned this pull request Jan 22, 2020
Merged
@rekmarks rekmarks requested a review from estebanmino January 22, 2020 05:22
Gudahtt
Gudahtt approved these changes Jan 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit cd4db14 into develop Jan 24, 2020
@rekmarks rekmarks deleted the no-shrinkwrap branch January 24, 2020 20:37
@whymarrh whymarrh mentioned this pull request Jan 24, 2020
Merged
@whymarrh whymarrh mentioned this pull request Feb 26, 2020
Closed
1 task
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
@dependabot
Bump @metamask/json-rpc-engine from 7.1.1 to 7.2.0 (#192)
6ae2346
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
@Gudahtt
Remove btoa (#192)
2bd3181 
The `btoa` function must now be passed in as a middleware option. This
lets us remove an additional dependency, and makes this package less
dependent upon Node.js or browser specific APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

+1 more reviewer

@estebanmino estebanmino estebanmino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rekmarks @Gudahtt @estebanmino