update addressBook with entries by chainId#152
Merged
Conversation
rekmarks
reviewed
Sep 3, 2019
Member
rekmarks
left a comment
There was a problem hiding this comment.
One minor inline comment, otherwise LGTM.
Codecov Report
@@ Coverage Diff @@
## develop #152 +/- ##
======================================
Coverage 100% 100%
======================================
Files 21 21
Lines 1432 1439 +7
Branches 192 193 +1
======================================
+ Hits 1432 1439 +7
Continue to review full report at Codecov.
|
jennypollack
commented
Sep 3, 2019
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
update addressBook with entries by chainId add isValidEns checking for address book name
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
update addressBook with entries by chainId add isValidEns checking for address book name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously the address book was only keyed by address, so a user was only allowed to have one entry per address regardless of network