Skip to content

Add ApprovalType enum#1174

Merged
vinistevam merged 7 commits intomainfrom
fix/add-approval-request-type
Apr 18, 2023
Merged

Add ApprovalType enum#1174
vinistevam merged 7 commits intomainfrom
fix/add-approval-request-type

Conversation

@vinistevam
Copy link
Copy Markdown
Contributor

@vinistevam vinistevam commented Apr 13, 2023 •
edited
Loading

Description

Changes

Included ApprovalType enum joining ApprovalTypes from mobile and some of the MESSAGE_TYPE from the extension.
Package: controller-utils

  • ADDED: ApprovalType enum to unify across clients

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@vinistevam vinistevam force-pushed the fix/add-approval-request-type branch from 34c6d3f to b43ab4f Compare April 13, 2023 10:44
@vinistevam vinistevam marked this pull request as ready for review April 13, 2023 11:12
@vinistevam vinistevam requested a review from a team as a code owner April 13, 2023 11:12
Mrtenz
Mrtenz reviewed Apr 13, 2023
View reviewed changes
Comment thread packages/controller-utils/src/constants.ts Outdated
@vinistevam vinistevam force-pushed the fix/add-approval-request-type branch from cdf2ed4 to 642057d Compare April 13, 2023 16:10
matthewwalsh0
matthewwalsh0 reviewed Apr 14, 2023
View reviewed changes
Comment thread packages/controller-utils/src/constants.ts
matthewwalsh0
matthewwalsh0 reviewed Apr 14, 2023
View reviewed changes
Comment thread packages/controller-utils/src/constants.ts Outdated
matthewwalsh0
matthewwalsh0 reviewed Apr 14, 2023
View reviewed changes
Comment thread packages/controller-utils/src/constants.ts Outdated
matthewwalsh0
matthewwalsh0 reviewed Apr 14, 2023
View reviewed changes
Comment thread packages/controller-utils/src/constants.ts Outdated
@vinistevam vinistevam changed the title Add APPROVAL_TYPES constant Add ApprovalType enum Apr 14, 2023
matthewwalsh0
matthewwalsh0 reviewed Apr 14, 2023
View reviewed changes
Comment thread packages/controller-utils/src/constants.ts Outdated
@vinistevam vinistevam force-pushed the fix/add-approval-request-type branch from 35af3b2 to 90ae8a7 Compare April 14, 2023 15:06
@vinistevam vinistevam merged commit deb4df4 into main Apr 18, 2023
@vinistevam vinistevam deleted the fix/add-approval-request-type branch April 18, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmire mcmire mcmire left review comments

@Mrtenz Mrtenz Mrtenz approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vinistevam @mcmire @Mrtenz @OGPoyraz @matthewwalsh0 @legobeat