Conversation
Mrtenz
reviewed
Mar 22, 2023
a845327 to
1ea1a3d
Compare
Gudahtt
reviewed
Mar 22, 2023
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Looks great! I had no blocking concerns, but wanted to learn more about that swallowed error before approving
3125916 to
d6056e9
Compare
d6056e9 to
4b6f478
Compare
4b6f478 to
bf5564e
Compare
ef82980 to
e06b102
Compare
e2e4cb8 to
e8597cc
Compare
matthewwalsh0
approved these changes
Mar 24, 2023
This was referenced Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SIWE detection method to
controller/utilsdetectSIWE(https://github.com/MetaMask/metamask-extension/blob/cedef121a36184cde4eae448ef510733fa301072/shared/modules/siwe.js#L34) method intocontroller/utilsso thatPersonalMessageManagercan consume it and potentially be used both on mobile and extension in the future.controller/utilsand delete the duplicated code within the extension.Description
ADDED:
controller/utilsChecklist