Skip to content

API-125 - Migrated from metaswap to metafi subdomain for proxy and token icons#1060

Merged
Gudahtt merged 1 commit intoMetaMask:mainfrom
blurpesec:API-125
Jan 17, 2023
Merged

API-125 - Migrated from metaswap to metafi subdomain for proxy and token icons#1060
Gudahtt merged 1 commit intoMetaMask:mainfrom
blurpesec:API-125

Conversation

@blurpesec
Copy link
Copy Markdown
Contributor

@blurpesec blurpesec commented Jan 11, 2023 •
edited
Loading

PR Title

  • Migrates from *.metaswap.codefi.network to *.metafi.codefi.network for proxy and static subdomains. MetaMask Platform API team is migrating from metaswap aws accounts to their own.

Description

Itemize the changes you have made into the categories below

  • BREAKING:

    • Uses new subdomains for providing the opensea proxy and token icons cache.

  • CHANGED:

    • Uses new subdomains for providing the opensea proxy and token icons cache.
    • New infrastructure enables a new mechanism to handle support requests for changes to token icons. Now https://github.com/MetaMask/contract-metadata will be the priority provider of icons, such that changes there will overwrite any existing token icons we're fetching and caching from other providers.

@blurpesec blurpesec requested a review from a team as a code owner January 11, 2023 18:49
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Jan 17, 2023 •
edited
Loading

Looks good! I checked this out locally and found 3 more references to "metaswap.codefi.network":

Have the token-api and api (legacy gas API) services been migrated as well? If so, perhaps these need to be updated.

@3uzbcqje
Copy link
Copy Markdown

3uzbcqje commented Jan 17, 2023

api.metaswap.codefi.network was decommissioned. token-api is still located at token-api.metaswap.codefi.network.

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Jan 17, 2023

Makes sense! Looks like there is now a conflict, but I can approve once that has been resolved

Gudahtt
Gudahtt approved these changes Jan 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 946edfe into MetaMask:main Jan 17, 2023
@cryptodev-2s cryptodev-2s mentioned this pull request May 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blurpesec @Gudahtt @3uzbcqje