Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 1420 1424 +4
Branches 182 182
=====================================
+ Hits 1420 1424 +4
Continue to review full report at Codecov.
|
3 tasks
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
* 5.0.3 * Update CHANGELOG.md * Update CHANGELOG.md and change to major version --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: david0xd <david@timechaser.org>
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
This PR adds [JSON-RPC 2.0](https://www.jsonrpc.org/specification)-compliant notification handling for `JsonRpcEngine`. - JSON-RPC notifications are defined as JSON-RPC request objects without an `id` property. - A new constructor parameter, `notificationHandler`, is introduced. This parameter is a function that accepts JSON-RPC notification objects and returns `void | Promise<void>`. - When `JsonRpcEngine.handle` is called, if a `notificationHandler` exists, any request objects duck-typed as notifications will be handled as such. This means that: - Validation errors that occur after duck-typing will be ignored. At the moment, this just means that no error will be thrown if the `method` field is not a string. - If basic validation succeeds, the notification object will be passed to the handler function without touching the middleware stack. - The response from `handle()` will be `undefined`. - No error will be returned or thrown, unless the notification handler itself throws or rejects. - Notification handlers should not throw or reject, and it is the implementer's responsibility to ensure that they do not. - If `JsonRpcEngine.handle` is called and no `notificationHandler` exists, notifications will be treated just like requests. This is the current behavior.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
This is a performance improvement as the latter is actually faster. json-stable-stringify x 13,870 ops/sec ±0.72% (94 runs sampled) safe-stable-stringify x 30,367 ops/sec ±0.39% (96 runs sampled)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a semaphore to
updateExchangeRate, this was causing wrong conversion rates.If the app sets native currency as ETH and then DAI,
fetchExchangeRatecould finish first for DAI, producing that ETH conversion rate is set to state because it finished later, even though it was called first.