Tests organization mv src/*ts.test tests/#101
Merged
frankiebee merged 2 commits intomasterfrom May 21, 2019
Merged
Conversation
4938aa0 to
9f9c79e
Compare
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 1418 1418
Branches 182 182
=====================================
Hits 1418 1418Continue to review full report at Codecov.
|
bitpshr
reviewed
May 21, 2019
Contributor
bitpshr
left a comment
There was a problem hiding this comment.
Looks great, just one question / comment.
src/AddressBookController.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| import BaseController, { BaseConfig, BaseState } from './BaseController'; | |||
| import BaseController, { BaseConfig, BaseState } from '../src/BaseController'; | |||
Contributor
There was a problem hiding this comment.
I think this import should still be './BaseController'.
Contributor
Author
There was a problem hiding this comment.
oh yeah good catch thanks
bitpshr
approved these changes
May 21, 2019
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
### Changed - The `Keyring` exposes a new optional method `init` ([MetaMask#99](MetaMask/utils#99)) ### Fixed - Bump `@ethereumjs/tx` to `4.1.2` to address runtime compatibility issues ([MetaMask#100](MetaMask/utils#100))
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](ajv-validator/ajv@v6.10.2...v6.12.6) --- updated-dependencies: - dependency-name: ajv dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
tests - move tests to test folder
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
tests - move tests to test folder
This was referenced Nov 8, 2023
Closed
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Bumps [tar](https://github.com/npm/node-tar) from 4.4.15 to 4.4.19. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v4.4.15...v4.4.19) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because this makes my life easier