Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MetaMask/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 157d483
Choose a base ref
...
head repository: MetaMask/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ba06ae9
Choose a head ref
  • 5 commits
  • 10 files changed
  • 2 contributors

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    900e739 View commit details
    Browse the repository at this point in the history
  2. Add submit history

    matthewwalsh0 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    dc7c2d7 View commit details
    Browse the repository at this point in the history
  3. Export constants

    matthewwalsh0 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ff20633 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    dab3c9f View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. fix: re-simulate transactions if security checks fail (#4792)

    <!--
    Thanks for your contribution! Take a moment to answer these questions so
    that reviewers have the information they need to properly understand
    your changes:
    
    * What is the current state of things and why does it need to change?
    * What is the solution your changes offer and how does it work?
    * Are there any changes whose purpose might not obvious to those
    unfamiliar with the domain?
    * If your primary goal was to update one package but you found you had
    to update another one along the way, why did you do so?
    * If you had to upgrade a dependency, why did you do so?
    -->
    
    This PR adds a mechanism to re-trigger of simulations if the security
    provider mark transaction as `malicious` and the previous simulation
    native balance change is different then the previous simulation.
    
    <!--
    Are there any issues that this pull request is tied to?
    Are there other links that reviewers should consult to understand these
    changes better?
    Are there client or consumer pull requests to adopt any breaking
    changes?
    
    For example:
    
    * Fixes #12345
    * Related to #67890
    -->
    
    Fixes: MetaMask/MetaMask-planning#3380
    
    <!--
    If you're making any consumer-facing changes, list those changes here as
    if you were updating a changelog, using the template below as a guide.
    
    (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or
    FIXED. For security-related issues, follow the Security Advisory
    process.)
    
    Please take care to name the exact pieces of the API you've added or
    changed (e.g. types, interfaces, functions, or methods).
    
    If there are any breaking changes, make sure to offer a solution for
    consumers to follow once they upgrade to the changes.
    
    Finally, if you're only making changes to development scripts or tests,
    you may replace the template below with "None".
    -->
    
    - **ADDED**: Add mechanism to re-trigger of simulations if the security
    provider mark transaction as `malicious` and the previous simulation
    native balance change is different then the previous simulation.
    - **ADDED**: Add `changeInSimulationData` property to `simulationData`
    in order to detect change of simulation data.
    
    - [X] I've updated the test suite for new or updated code as appropriate
    - [X] I've updated documentation (JSDoc, Markdown, etc.) for new or
    updated code as appropriate
    - [X] I've highlighted breaking changes using the "BREAKING" category
    above as appropriate
    - [X] I've prepared draft pull requests for clients and consumer
    packages to resolve any breaking changes
    
    ---------
    
    Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
    OGPoyraz and matthewwalsh0 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ba06ae9 View commit details
    Browse the repository at this point in the history
Loading