-
-
Notifications
You must be signed in to change notification settings - Fork 277
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: MetaMask/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 157d483
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: MetaMask/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ba06ae9
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 10 files changed
- 2 contributors
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 900e739 - Browse repository at this point
Copy the full SHA 900e739View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc7c2d7 - Browse repository at this point
Copy the full SHA dc7c2d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff20633 - Browse repository at this point
Copy the full SHA ff20633View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dab3c9f - Browse repository at this point
Copy the full SHA dab3c9fView commit details
Commits on Oct 29, 2024
-
fix: re-simulate transactions if security checks fail (#4792)
<!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> This PR adds a mechanism to re-trigger of simulations if the security provider mark transaction as `malicious` and the previous simulation native balance change is different then the previous simulation. <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> Fixes: MetaMask/MetaMask-planning#3380 <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> - **ADDED**: Add mechanism to re-trigger of simulations if the security provider mark transaction as `malicious` and the previous simulation native balance change is different then the previous simulation. - **ADDED**: Add `changeInSimulationData` property to `simulationData` in order to detect change of simulation data. - [X] I've updated the test suite for new or updated code as appropriate - [X] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [X] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [X] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
Configuration menu - View commit details
-
Copy full SHA for ba06ae9 - Browse repository at this point
Copy the full SHA ba06ae9View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 157d483...ba06ae9