Merged
Conversation
rickycodes
added a commit
to MetaMask/KeyringController
that referenced
this pull request
May 27, 2023
This fixes the broken subteam tagging that was patched in MetaMask/action-npm-publish#44 same as MetaMask/core#1398
rickycodes
added a commit
to MetaMask/metamask-module-template
that referenced
this pull request
May 27, 2023
## Description This fixes the broken subteam tagging that was patched in MetaMask/action-npm-publish#44 same as MetaMask/core#1398 same as MetaMask/KeyringController#232
rickycodes
added a commit
to MetaMask/KeyringController
that referenced
this pull request
May 27, 2023
* Make use of the new subteam functionality This fixes the broken subteam tagging that was patched in MetaMask/action-npm-publish#44 same as MetaMask/core#1398 * don't bump here
rickycodes
added a commit
to MetaMask/metamask-module-template
that referenced
this pull request
May 27, 2023
## Description This fixes the broken subteam tagging that was patched in MetaMask/action-npm-publish#44 same as MetaMask/core#1398 same as MetaMask/KeyringController#232
rickycodes
added a commit
that referenced
this pull request
May 27, 2023
Update to match functionality landed in #44
Merged
rickycodes
added a commit
that referenced
this pull request
May 30, 2023
Update to match functionality landed in #44
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay! our deployment today failed to tag the subteam because I didn't have this configured properly. I had assumed the functionality for tagging individuals and subteams was identical, but I was wrong! see: https://api.slack.com/reference/surfaces/formatting#mentioning-groups
I've tested this out in a private channel in our Slack instance and it works properly now: