Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Update module name to use @metamask scope#187

Merged
adonesky1 merged 2 commits intomainfrom
update-module-name
Dec 21, 2022
Merged

Update module name to use @metamask scope#187
adonesky1 merged 2 commits intomainfrom
update-module-name

Conversation

@adonesky1
Copy link
Copy Markdown
Contributor

Is there any reason we shouldn't use the @metamask namespace/scope for this package?

@adonesky1 adonesky1 requested a review from a team as a code owner December 21, 2022 17:59
@adonesky1 adonesky1 requested review from Gudahtt and mcmire December 21, 2022 17:59
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, no reason! The README still needs an update to reflect this rename though.

@adonesky1 adonesky1 requested a review from Gudahtt December 21, 2022 21:37
@adonesky1
Copy link
Copy Markdown
Contributor Author

updated here @Gudahtt !

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit 3e12995 into main Dec 21, 2022
@adonesky1 adonesky1 deleted the update-module-name branch December 21, 2022 21:40
@adonesky1 adonesky1 mentioned this pull request Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants