This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Update GitHub actions to match module template#158
Merged
Conversation
7454082 to
492e417
Compare
5f8d870 to
23dc493
Compare
Gudahtt
commented
Nov 9, 2022
| YARN_VERSION: ${{ steps.yarn-version.outputs.YARN_VERSION }} | ||
| strategy: | ||
| matrix: | ||
| node-version: [14.x, 16.x, 18.12.1, 19.x] |
Member
Author
There was a problem hiding this comment.
Node.js v18 has been temporarily pinned to v18.12.1 because there is a range of versions (including v18.12.0, which is the default choice of actions/setup-node for v18.x) that blows up during the unit tests due to an SSL error. This was fixed in v18.12.1.
We can change this back to v18.x once actions/setup-node updates and their caches are populated with some version >=v18.12.1
The GitHub actions have been updated to match the module template more closely. There are still many differences because this library is not yet using TypeScript, so it doesn't have any build step. It also doesn't yet have API documentation, so steps relating to that have been removed. Release instructions have been added to the README as well.
23dc493 to
8872c32
Compare
Member
Author
|
See here for the module template workflows: https://github.com/MetaMask/metamask-module-template/tree/main/.github/workflows |
mcmire
approved these changes
Nov 9, 2022
darkwing
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub actions have been updated to match the module template more closely. There are still many differences because this library is not yet using TypeScript, so it doesn't have any build step. It also doesn't yet have API documentation, so steps relating to that have been removed.