fix: prevent deadlock in gun.Conn.Close when initReader is in progress#2651
Merged
Conversation
Close() called initOnce.Do() which blocks if initReader is already running inside initFn (e.g. HTTP2 RoundTrip stuck on network I/O). This caused worker goroutines to hang forever during alive checks. Fix: close the pipe writer first to unblock initFn, then call initOnce.Do() which is now guaranteed to return promptly.
Collaborator
|
I've revised the code to be clearer; you can test it to see if it resolves the deadlock issue. |
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close() called initOnce.Do() which blocks if initReader is already running inside initFn (e.g. HTTP2 RoundTrip stuck on network I/O). This caused worker goroutines to hang forever during alive checks.
Fix: close the pipe writer first to unblock initFn, then call initOnce.Do() which is now guaranteed to return promptly.