Skip to content

Support for mono #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
potterdai wants to merge 2 commits into from
Closed

Support for mono #155

potterdai wants to merge 2 commits into from

Conversation

@potterdai
Copy link

@potterdai potterdai commented Nov 2, 2017

Inspired by Cysharp/MagicOnion#45
This will allow mpc.exe run on Mono, supporting Mac and Linux.

neuecc added a commit that referenced this pull request Dec 22, 2017
@neuecc
support for mono, VS15.0, new csproj #155
252e6db
@neuecc
Copy link
Member

neuecc commented Dec 22, 2017

thanks!
it conflicted so I'll hand ported and pushed.
Please wait next release.

@neuecc neuecc closed this Dec 22, 2017
@neuecc
Copy link
Member

neuecc commented Dec 22, 2017

I've released 1.7.3, it includes this PR. thanks.

@DaniilSokolyuk
Copy link
Contributor

DaniilSokolyuk commented Dec 28, 2017

Nice! Thanks 👍

@slvmnd
Copy link

slvmnd commented Dec 31, 2017

I was unable to run mpc on mac, when running mpc on any solution file (i tried with my own and also the sandbox/SharedData example) this is the result:

Project Compilation Start:SharedData.csproj
[Failure] Msbuild failed when processing the file '/Users/slvmnd/Downloads/MessagePack-CSharp-1.7.3/sandbox/SharedData/SharedData.csproj' with message: GetEnvironmentStrings
Project Compilation Complete:00:00:00.9029542

Method Collect Start
Method Collect Complete:00:00:00.0016538
Output Generation Start
[Out]hej.cs
String Generation Complete:00:00:00.0100425

The output file has some code but doesn't contain anything about the types in the solution.

@potterdai
Copy link
Author

potterdai commented Dec 31, 2017

@slvmnd You should try this version for now
https://github.com/PotterDai/MessagePack-CSharp/releases
Something seems broken when this PR is merged and upgraded to the latest dotnet packages.

@slvmnd
Copy link

slvmnd commented Jan 1, 2018

Thanks @potterdai that version does indeed work for me. And also thanks to @neuecc for making this great library!

@LordDevil1980 LordDevil1980 mentioned this pull request Jan 23, 2018
Closed
@y0n3t4n1
Copy link

y0n3t4n1 commented Mar 10, 2018

The latest official release, MessagePack.Unity.1.7.3.zip, is still broken on Mac OS X. @neuecc @potterdai Would you replace it with the working version?

@neuecc neuecc mentioned this pull request Mar 14, 2018
Closed
@neuecc neuecc mentioned this pull request Apr 18, 2018
Closed
@liber-takano
Copy link

liber-takano commented Aug 29, 2018

@potterdai
I tried mpc.exe in https://github.com/PotterDai/MessagePack-CSharp/releases/download/v1.7.3/MessagePack.Unity.1.7.3.zip

but no generated code...

  • mac.
  • Unity 2018.2.1f1
$ mono --version
Mono JIT compiler version 5.12.0.301 (2018-02/4fe3280bba1 Fri Jul 20 08:25:42 EDT 2018)

$ mono mpc.exe -i  xxxxx/Assembly-CSharp.csproj -o MessagePackGenerated.cs
Project Compilation Start:xxxxx/Assembly-CSharp.csproj
[Failure] Msbuild failed when processing the file 'xxxxx/Assembly-CSharp.csproj'
[Failure] Msbuild failed when processing the file 'xxxxx/yyyy.csproj'
...
Project Compilation Complete:00:00:08.4514155

Method Collect Start
Method Collect Complete:00:00:00.0016771
Output Generation Start
[Out]MessagePackGenerated.cs
String Generation Complete:00:00:00.0120077

@cy-yusuke-abe
Copy link

cy-yusuke-abe commented Nov 1, 2018

mono version 5.8.1.0 works well.

AArnott added a commit to AArnott/MessagePack-CSharp that referenced this pull request Mar 11, 2023
@AArnott
Merge pull request MessagePack-CSharp#155 from AArnott/fixInstallSdk
c6afb21 
Fix several Install-DotNetSdk issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@potterdai @neuecc @DaniilSokolyuk @slvmnd @y0n3t4n1 @liber-takano @cy-yusuke-abe