You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
related to #1343
Latest unity adds .NET Standard 2.1 support, it causes some warnings.
Especially HashCode's #if !NETCOREAPP does not work on Unity.
If Unity targets netstandard2.1, defines NET_STANDARD_2_0 and NET_STANDARD.
Unity that does not support netstandard2.1 will not define NET_STANDARD.
So we can use NET_STANDARD to detect netstandard2.1.
This sounds like goodness, but till we have unity builds working it's hard to accept any PR in this repo. Our efforts to unblock unity, mac and linux agents are across #1312 and #1345 PRs. We're all set except that unity in #1312 just hangs forever during the build. Can you help, @neuecc ?
Woot! I got the master branch build passing again in #1345 by a combination of code changes and getting a build agent running with the original Unity editor v2019.1.10f1 that has worked in the past.
We certainly should still update the version of unity we're using. I have an agent with 2020.3.17f1 ready to go. To move the pipeline to it, we just need to change https://github.com/neuecc/MessagePack-CSharp/blob/ae79dc68e8fe4f03f4c19bd76e4d1f8bb7c5a984/azure-pipelines.yml#L38
As the line to be changed was only just introduced in master, if you want to update as part of this PR, you'll have to merge master into your source branch.
@AArnott
I've merged orign/master, however Unity agent is stalled The agent request is not running because all potential agents are running other requests. Current position in queue: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #1343
Latest unity adds .NET Standard 2.1 support, it causes some warnings.
Especially
HashCode's#if !NETCOREAPPdoes not work on Unity.If Unity targets
netstandard2.1, definesNET_STANDARD_2_0andNET_STANDARD.Unity that does not support
netstandard2.1will not defineNET_STANDARD.So we can use
NET_STANDARDto detectnetstandard2.1.Othes,
Tests.asmdefdefinesMsgPack.dll.