Skip to content

Support Unity netstandard21#1346

Merged
AArnott merged 5 commits intomasterfrom
unity-netstandard21
Nov 9, 2021
Merged

Support Unity netstandard21#1346
AArnott merged 5 commits intomasterfrom
unity-netstandard21

Conversation

@neuecc
Copy link
Copy Markdown
Member

@neuecc neuecc commented Nov 4, 2021

related to #1343
Latest unity adds .NET Standard 2.1 support, it causes some warnings.
Especially HashCode's #if !NETCOREAPP does not work on Unity.

If Unity targets netstandard2.1, defines NET_STANDARD_2_0 and NET_STANDARD.
Unity that does not support netstandard2.1 will not define NET_STANDARD.
So we can use NET_STANDARD to detect netstandard2.1.

Othes, Tests.asmdef defines MsgPack.dll.

@AArnott
Copy link
Copy Markdown
Collaborator

AArnott commented Nov 4, 2021

This sounds like goodness, but till we have unity builds working it's hard to accept any PR in this repo. Our efforts to unblock unity, mac and linux agents are across #1312 and #1345 PRs. We're all set except that unity in #1312 just hangs forever during the build. Can you help, @neuecc ?

@neuecc
Copy link
Copy Markdown
Member Author

neuecc commented Nov 5, 2021

Oh, I'll contact my companie's build engineer to resolve it.
Please wait for a next begining of the week.

@AArnott
Copy link
Copy Markdown
Collaborator

AArnott commented Nov 5, 2021

Woot! I got the master branch build passing again in #1345 by a combination of code changes and getting a build agent running with the original Unity editor v2019.1.10f1 that has worked in the past.
We certainly should still update the version of unity we're using. I have an agent with 2020.3.17f1 ready to go. To move the pipeline to it, we just need to change
https://github.com/neuecc/MessagePack-CSharp/blob/ae79dc68e8fe4f03f4c19bd76e4d1f8bb7c5a984/azure-pipelines.yml#L38

like so

-      - UNITYVERSION -equals 2019.1
+      - UNITYVERSION -equals 2020.3

As the line to be changed was only just introduced in master, if you want to update as part of this PR, you'll have to merge master into your source branch.

@neuecc
Copy link
Copy Markdown
Member Author

neuecc commented Nov 8, 2021

@AArnott
I've merged orign/master, however Unity agent is stalled The agent request is not running because all potential agents are running other requests. Current position in queue: 1

@AArnott
Copy link
Copy Markdown
Collaborator

AArnott commented Nov 8, 2021

@neuecc The build agent had shut down. I've restarted it and configured it to restart itself next time.

@neuecc
Copy link
Copy Markdown
Member Author

neuecc commented Nov 9, 2021

@AArnott thanks, all builds passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants