Skip to content

Refactory ObjectSerializationInfo.CreateOrNull#1302

Merged
AArnott merged 2 commits intoMessagePack-CSharp:masterfrom
fredliex:refactory-ObjectSerializationInfo.CreateOrNull
Aug 21, 2021
Merged

Refactory ObjectSerializationInfo.CreateOrNull#1302
AArnott merged 2 commits intoMessagePack-CSharp:masterfrom
fredliex:refactory-ObjectSerializationInfo.CreateOrNull

Conversation

@fredliex
Copy link
Copy Markdown
Contributor

@fredliex fredliex commented Aug 4, 2021

Refactoring of ObjectSerializationInfo.CreateOrNull for #1297

Mainly to reduce some repetitive code.
The logic remains the same.

@AArnott
Copy link
Copy Markdown
Collaborator

AArnott commented Aug 21, 2021

Thanks. I'm not as familiar with this code so it'll take me a little more time to study to verify that this makes no accidental behavioral changes.

Copy link
Copy Markdown
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Thanks.

@AArnott AArnott added this to the v2.3 milestone Aug 21, 2021
@AArnott AArnott merged commit 14556ae into MessagePack-CSharp:master Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants