Conversation
|
Hey thx! I have a question regarding your change: does using attribute without compiler work on .Net Standard 2.0?
I believe it doesn’t? At least with StandardResolver they do not appear to work. I don’t see a way to register a resolver for my custom class without using compiler.
I would love to see this clarified :)
…Sent from my Phone
On Jun 14, 2021, at 5:56, Andrew Arnott ***@***.***> wrote:
In response to @bitinn's suggestion here: #471 (comment)
You can view, comment on, or merge this pull request online at:
#1264
Commit Summary
Clearly document unity scenarios that require AOT
File Changes
M README.md (7)
Patch Links:
https://github.com/neuecc/MessagePack-CSharp/pull/1264.patch
https://github.com/neuecc/MessagePack-CSharp/pull/1264.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I meant attribute like DataContract or MessagePackObject. It seems like I have to use compiler code-gen on .Net Standard 2.0 + mono? Love to see a usage matrix to be honest.
…Sent from my Phone
On Jun 14, 2021, at 10:51, David Frank ***@***.***> wrote:
Hey thx! I have a question regarding your change: does using attribute without compiler work on .Net Standard 2.0?
I believe it doesn’t? At least with StandardResolver they do not appear to work. I don’t see a way to register a resolver for my custom class without using compiler.
I would love to see this clarified :)
Sent from my Phone
>> On Jun 14, 2021, at 5:56, Andrew Arnott ***@***.***> wrote:
>>
>
> In response to @bitinn's suggestion here: #471 (comment)
>
> You can view, comment on, or merge this pull request online at:
>
> #1264
>
> Commit Summary
>
> Clearly document unity scenarios that require AOT
> File Changes
>
> M README.md (7)
> Patch Links:
>
> https://github.com/neuecc/MessagePack-CSharp/pull/1264.patch
> https://github.com/neuecc/MessagePack-CSharp/pull/1264.diff
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
|
Collaborator
Author
|
I don't have the answers to your questions, as Unity isn't my area. Hopefully @neuecc can clarify. |
Member
|
If you mean Custom class, and you want it to be automatically serializable for Custom class, it won't work. |
(I am on .Net Standard 2.0, instead of .Net 4.x) |
Collaborator
Author
|
@bitinn: you need one formatter per type to be serialized. A formatter needs a resolver to find it. So at minimum for 10 types, you need 10 formatters and 1 resolver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to @bitinn's suggestion here: #471 (comment)