Draft PR: #1085 Solution for mpc.exe#1092
Closed
pCYSl5EDgo wants to merge 16 commits intoMessagePack-CSharp:developfrom
Closed
Draft PR: #1085 Solution for mpc.exe#1092pCYSl5EDgo wants to merge 16 commits intoMessagePack-CSharp:developfrom
pCYSl5EDgo wants to merge 16 commits intoMessagePack-CSharp:developfrom
Conversation
This is a refactoring of int-key mpc.exe tt file.
Change the iterator `i` type from `int` to `var`.
Revert: DepthStep position Revert: }#> -> } #>
AArnott
requested changes
Oct 25, 2020
Collaborator
AArnott
left a comment
There was a problem hiding this comment.
Looks pretty good. Just a few questions/suggestions.
| @@ -0,0 +1,21 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
Collaborator
There was a problem hiding this comment.
I'm not sure we need a new project for generated code tests. Don't we already have a bunch of unit tests in the general MessagePack.Tests project that operate on the sandbox generated types?
I don't object to this project, but I'm struggling to reason about why we would divide the generated code tests across a dedicated and a mixed test project.
Contributor
Author
There was a problem hiding this comment.
tests/MessagePack.Tests does not include sandbox/Sandbox but sandbox/SharedData.
I guessed there was a reason not to include generated C# codes into the tests/MessagePack.Tests whose codes are in the Unity folder.
If you have no objection to link sandbox/Sandbox to tests/MessagePack.Tests, I would like to link them together.
AArnott
approved these changes
Oct 26, 2020
pCYSl5EDgo
added a commit
to pCYSl5EDgo/MessagePack-CSharp
that referenced
this pull request
Oct 27, 2020
…rp#1092 commit d7a50b9 Merge: 02ae418 5a6cda6 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Mon Oct 26 09:33:45 2020 +0900 Merge remote-tracking branch 'upstream/develop' into solution#1085-mpc commit 02ae418 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Mon Oct 26 09:25:20 2020 +0900 Update: Loop demonstration commit d84ae75 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Mon Oct 26 09:24:31 2020 +0900 Change: drop deserialized value -> reader.Skip() commit 9b0d4a2 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Mon Oct 26 00:27:10 2020 +0900 Fix: remove unused boolean local variables commit fdfabeb Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Mon Oct 26 00:00:28 2020 +0900 Update: Make the same as Dynamic commit bef4692 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Sun Oct 25 19:37:11 2020 +0900 Add test project commit a8fac80 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Sun Oct 25 18:55:27 2020 +0900 Add types to sandbox commit 6ffc3c3 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Sun Oct 25 18:45:40 2020 +0900 Update: string-key mpc.exe commit 44819e6 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Sun Oct 25 18:05:24 2020 +0900 Update: int-key mpc.exe commit 0a2fef4 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Sun Oct 25 12:12:57 2020 +0900 Fix: var -> global::MessagePack.IFormatterResolver commit 086aa11 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Sun Oct 25 12:05:21 2020 +0900 Fix: Line Feed commit 39d3d08 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Sun Oct 25 12:03:37 2020 +0900 Fix: space commit c57f423 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Sun Oct 25 12:00:32 2020 +0900 Change: var to globall:: Revert: DepthStep position Revert: }#> -> } #> commit de6fd23 Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Sat Oct 24 11:04:44 2020 +0900 fix CRLF commit 4b6ae7c Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Sat Oct 24 10:59:50 2020 +0900 Change the format to decrease template part lines. Change the iterator `i` type from `int` to `var`. commit 95f41ad Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp> Date: Fri Oct 23 21:03:54 2020 +0900 This is a cherry-pick of MessagePack-CSharp#1074. This is a refactoring of int-key mpc.exe tt file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find a behaviour mismatch between mpc.exe and DynamicObjectResolver.
If a member belongs to constructor parameters, the assignment is skipped in Dynamic.
I changed the mpc.exe to be the same as the DynamicObjectResolver.