Skip to content

Draft PR: #1085 solution for Dynamic#1091

Closed
pCYSl5EDgo wants to merge 6 commits intoMessagePack-CSharp:developfrom
pCYSl5EDgo:solution#1085-Dynamic
Closed

Draft PR: #1085 solution for Dynamic#1091
pCYSl5EDgo wants to merge 6 commits intoMessagePack-CSharp:developfrom
pCYSl5EDgo:solution#1085-Dynamic

Conversation

@pCYSl5EDgo
Copy link
Copy Markdown
Contributor

bool canOverwrite for the future circular reference support.

Copy link
Copy Markdown
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me (aside from the canOverwrite stuff that's confusing me). @neuecc do you have any feedback?

pCYSl5EDgo added a commit to pCYSl5EDgo/MessagePack-CSharp that referenced this pull request Oct 27, 2020
…rp#1091

commit 5fbf110
Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp>
Date:   Mon Oct 26 18:12:45 2020 +0900

    make BuildDeserialize easy to understand

commit 292badc
Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp>
Date:   Mon Oct 26 13:47:48 2020 +0900

    Update: Rename LocalField -> LocalVariable

commit 007e338
Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp>
Date:   Mon Oct 26 13:12:38 2020 +0900

    Add test code for setter call after explicit constructor

commit 5181801
Merge: 5948fc0 5a6cda6
Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp>
Date:   Mon Oct 26 12:59:36 2020 +0900

    Merge branch 'develop' of https://github.com/neuecc/MessagePack-CSharp into solution#1085-Dynamic

commit 5948fc0
Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp>
Date:   Sun Oct 25 21:18:12 2020 +0900

    Add tests

commit 96aaa6a
Author: pCYSl5EDgo <pCYSl5EDgo@yahoo.co.jp>
Date:   Sun Oct 25 20:25:44 2020 +0900

    Update: DynamicObjectResolver
@pCYSl5EDgo pCYSl5EDgo closed this Oct 27, 2020
@pCYSl5EDgo pCYSl5EDgo deleted the solution#1085-Dynamic branch December 29, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants