Skip to content

Conversation

@martinpucik
Copy link
Contributor

@martinpucik martinpucik commented Jul 30, 2022

What does this implement/fix? Explain your changes.

  • Fixed plugins setup on main
  • Added option to lint from makefile
  • Added option to set up git hooks from makefile

Does this close any currently open issues?

Closes #1731

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

Devices/Simulators:

iOS Version:

Swift Version:

MessageKit Version:

Added swiftlint command line plugin
Try makefile for CI runs
Try makefile for CI runs
Try swiftlint bin from SwiftPM
Resolve spm before running danger lint
Resolve spm before running danger lint
Test failures reporting on CI
Test failures reporting on CI
Test failures reporting on CI
Revert failing code
Revert failing code
Cleanup unused files
Makefile setup for git hooks
@martinpucik martinpucik marked this pull request as ready for review July 31, 2022 12:29
@martinpucik martinpucik enabled auto-merge (squash) July 31, 2022 12:30
@martinpucik martinpucik merged commit 14dd6aa into main Jul 31, 2022
@martinpucik martinpucik deleted the fix-plugins branch July 31, 2022 12:37
Patrick-Kladek pushed a commit to medbee/MessageKit that referenced this pull request Oct 25, 2023
* fix: SwiftPM plugins

* fix: SwiftPM plugins

Added swiftlint command line plugin

* fix: SwiftPM plugins

Try makefile for CI runs

* fix: SwiftPM plugins

Try makefile for CI runs

* fix: SwiftPM plugins

Try swiftlint bin from SwiftPM

* fix: SwiftPM plugins

Resolve spm before running danger lint

* fix: SwiftPM plugins

Resolve spm before running danger lint

* fix: SwiftPM plugins

Changelog

* fix: SwiftPM plugins

Test failures reporting on CI

* fix: SwiftPM plugins

Test failures reporting on CI

* fix: SwiftPM plugins

Test failures reporting on CI

* fix: SwiftPM plugins

Revert failing code

* fix: SwiftPM plugins

Revert failing code

* fix: SwiftPM plugins

Cleanup unused files

* fix: SwiftPM plugins

Makefile setup for git hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installing latest version fails due to SwiftFormatPlugin

3 participants